A way to disable default PropertiesConfigReader#534
Open
xbaran wants to merge 4 commits intoNetflix:2.xfrom
Open
A way to disable default PropertiesConfigReader#534xbaran wants to merge 4 commits intoNetflix:2.xfrom
xbaran wants to merge 4 commits intoNetflix:2.xfrom
Conversation
added 4 commits
December 18, 2017 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find myself unable to disable default PropertiesConfigReader reader in InternalArchaiusModule which is package private and final.
I think more suitable place for default reader config is in ArchaiusModule as protected method.
So when I want to change PropertiesConfigReader for TypesafeConfigReader it would look like this:
Well I have another fix for TypesafeConfigReader that support Lists,Maps and Sets