Skip to content

A way to disable default PropertiesConfigReader#534

Open
xbaran wants to merge 4 commits intoNetflix:2.xfrom
xbaran:2.x
Open

A way to disable default PropertiesConfigReader#534
xbaran wants to merge 4 commits intoNetflix:2.xfrom
xbaran:2.x

Conversation

@xbaran
Copy link
Copy Markdown

@xbaran xbaran commented Dec 18, 2017

I find myself unable to disable default PropertiesConfigReader reader in InternalArchaiusModule which is package private and final.

I think more suitable place for default reader config is in ArchaiusModule as protected method.

So when I want to change PropertiesConfigReader for TypesafeConfigReader it would look like this:

install(new ArchaiusModule() {
@Override
protected void bindDefaultReaders() {}
@Override
protected void configureArchaius() {    Multibinder.newSetBinder(this.binder(),ConfigReader.class).addBinding().to(TypesafeConfigReader.class).asEagerSingleton();
}
});

Well I have another fix for TypesafeConfigReader that support Lists,Maps and Sets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants