Load properties for @ConfigurationSource on @Provides methods#575
Open
elandau wants to merge 1 commit intoNetflix:2.xfrom
Open
Load properties for @ConfigurationSource on @Provides methods#575elandau wants to merge 1 commit intoNetflix:2.xfrom
elandau wants to merge 1 commit intoNetflix:2.xfrom
Conversation
Loading configuration with @provides methods currently requires a hack to inject a second type that is annotated with @ConfigurationSource. This change makes it possible to annotate the @provides with with @ConfigurationSource to have the configuration loaded before the bean is provisioned. For example, ``` @ConfigurationSource({"foo"}) @provides @singleton Foo getFoo() { } ``` will result in foo.properties (and it's variants) being loaded before getFoo is called.
elandau
force-pushed
the
feature/at_provides_configuration_source
branch
from
ef7444e to
b923dcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading configuration with @provides methods currently requires a hack to inject a second type that is annotated with @ConfigurationSource. This change makes it possible to annotate the @provides method with @ConfigurationSource to have the configuration loaded before the bean is provisioned. For example,
will result in foo.properties (and it's variants) being loaded before getFoo is called.