Conversation
…xies This is a re-factor of the code reverted in PR Netflix#685, originally by @kilink
|
I've also realized that, since a ConfigProxyFactory is always initialized after the config object it proxies ... we could have a flag to disable use of lambdas! So anyone hit by the weirdness can just set the flag and keep on leaking proxies to their hearts contents 😁 |
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
I remember loving this project, and randomly took a look since such an interesting situation. Pay no mind to my unsolicited 2p unless you care to!
| } else { // Java 17 onwards | ||
| INSTANCE = new LambdasFactory(); | ||
| } | ||
| LOG.info("Choosing {} as invoker factory for default methods", INSTANCE.getClass()); |
There was a problem hiding this comment.
is info or debug more sensible for this?
|
|
||
| // The threshold is simply a best guess. Creating 1000 lambdas for the same interface is almost certainly | ||
| // a leak, right? | ||
| private static final int MAX_SEEN_THRESHOLD = 1000; |
There was a problem hiding this comment.
would a JMH bench trigger stuff like this?
| * provides a noticeable performance boost. This implementation is known to fail in java 9 - 11. It *should* work | ||
| * from 12 or 13 onwards, but we have only tested it in 17 and 21. | ||
| */ | ||
| private static class LambdasFactory extends DefaultMethodInvokerFactory { |
There was a problem hiding this comment.
if package-scoped (final, too) you could make a matrix test and benchmarks, or even fuzzing to rely less on seen in usage stuff.
2 participants
This PR re-introduces the usage of lambdas for config proxies. I refactored things into a separate class and split the implementations for different JVMs to make things cleaner. I also introduced a "usage counter" circuit breaker to reduce the chance that users could hit OOM errors like they did before. I'll probably end up removing that later, thought.
There's also a bunch of compiler warning cleanups. I tried to keep those on a separate commit so the actual change is easier to review.