Skip to content

Make GenerateJavaTask.schemaPaths lazy instead of @Input List<Any> (fixes #952) #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshit6392 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −3
Open

Make GenerateJavaTask.schemaPaths lazy instead of @Input List<Any> (fixes #952) #956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions ...codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/GenerateJavaTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.netflix.graphql.dgs.codegen.JacksonVersion
import com.netflix.graphql.dgs.codegen.Language
import org.gradle.api.DefaultTask
import org.gradle.api.file.ConfigurableFileCollection
import org.gradle.api.file.FileCollection
import org.gradle.api.model.ObjectFactory
import org.gradle.api.plugins.JavaPlugin
import org.gradle.api.provider.ListProperty
Expand All @@ -48,8 +49,22 @@ open class GenerateJavaTask
.get()
.asFile.absolutePath

@InputFiles
var schemaPaths = mutableListOf<Any>("${project.projectDir}/src/main/resources/schema")
@get:InputFiles
@get:PathSensitive(PathSensitivity.RELATIVE)
val schemaPaths: ConfigurableFileCollection =
objectFactory.fileCollection().from("${project.projectDir}/src/main/resources/schema")

fun setSchemaPaths(paths: Iterable<Any>) {
schemaPaths.setFrom(paths)
}

fun setSchemaPaths(paths: Provider<out Iterable<Any>>) {
schemaPaths.setFrom(paths)
}

fun setSchemaPaths(paths: FileCollection) {
schemaPaths.setFrom(paths)
}

@Input
var packageName = "com.netflix.dgs.codegen.generated"
Expand Down Expand Up @@ -207,7 +222,7 @@ open class GenerateJavaTask
@TaskAction
fun generate() {
val schemaJarFilesFromDependencies = dgsCodegenClasspath.files.toList()
val schemaPaths = schemaPaths.map { Paths.get(it.toString()).toFile() }.sorted().toSet()
val schemaPaths = schemaPaths.files.sorted().toSet()
schemaPaths.filter { !it.exists() }.forEach {
logger.warn("Schema location ${it.absolutePath} does not exist")
}
Expand Down
Loading