fix: Replace static %d placeholders with AtomicInteger in thread factories#1583
Open
imyxiao wants to merge 1 commit intoNetflix:2.xfrom
Open
fix: Replace static %d placeholders with AtomicInteger in thread factories#1583imyxiao wants to merge 1 commit intoNetflix:2.xfrom
imyxiao wants to merge 1 commit intoNetflix:2.xfrom
Conversation
spencergibb
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves thread naming issues caused by removing Guava's
ThreadFactoryBuilderin #1526. Previously, thread names likeEureka-Worker-%drelied on Guava's formatting. This PR replaces%dwithAtomicIntegerto generate unique names (e.g.,Eureka-Worker-1).Changes
AtomicIntegerto dynamically number threads.