Upgrade commons-lang to commons-lang3 and refactor commons-configuration usage#1615
Open
krusche wants to merge 1 commit intoNetflix:masterfrom
Open
Upgrade commons-lang to commons-lang3 and refactor commons-configuration usage#1615krusche wants to merge 1 commit intoNetflix:masterfrom
krusche wants to merge 1 commit intoNetflix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commons-lang:2.xtocommons-lang3:3.20.0commons-configurationConfiguration interfacecommons-lang3dependency (previously pulled transitively)Fixes #1603
Changes
Dependencies (
build.gradle,eureka-client/build.gradle)commons-lang3:3.20.0as explicit dependencycommons-configuration:1.10(required at compile time byarchaius-core:0.7.6)Code changes
PropertiesInstanceConfig.java: RefactoredgetMetadataMap()to useConfigurationManager.getConfigInstance()directly instead of casting toConfigurationinterfaceDiscoveryClient.java: Updated import fromorg.apache.commons.lang.exception.ExceptionUtilstoorg.apache.commons.lang3.exception.ExceptionUtilsRedirectingEurekaHttpClient.java: Same import updateNotes
commons-configuration:1.10cannot be fully removed becausearchaius-core:0.7.6requires it at compile time (its API returnsAbstractConfigurationtypes)commons-configuration2would require upgrading toarchaius2, which is a larger breaking change affecting 24+ fileseureka-client-archaius2module already exists as an alternative for users who want archaius2 supportTesting