Refactor InternalPrefixedConfig to use StringBuilder for namespace construction#1619
Open
omer-cengel wants to merge 1 commit intoNetflix:masterfrom
Open
Conversation
marconi-prog
approved these changes
Feb 1, 2026
marconi-prog
left a comment
marconi-prog
left a comment
There was a problem hiding this comment.
LGTM 👍
Clean refactor, behavior preserved, and tests added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored InternalPrefixedConfig to avoid String concatenation inside a loop by using StringBuilder.
Problem
The constructor of InternalPrefixedConfig was building the namespace prefix using String concatenation (+=) inside a loop, which is less efficient due to repeated String object creation.
Changes Made
Result
The code is more efficient, and clearer, with no behavioral changes.
Fixes
Fixes #1606