fix: updated docs to include API proxying walkthrough, theme system UI Consistency and dev fixes#179
Open
Vinyl-Davyl wants to merge 3 commits intoNetflix:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is a multi-faceted refinement of the Metaflow UI codebase, focusing on design system consistency, test reliability, and technical documentation for onboarding.
Detailed the Technical Infrastructure (API Proxying) to help new developers understand how the UI communicates with the backend via
src/setupProxy.jsCorrected malformed CSS variable references where triple-dashes were used (---color-text-primary -> --color-text-primary).
TaskListLabel.tsxwhere a link color used a bare string instead of a var() wrapper, causing regression in link visibility.Code Quality: Performed a sweep for common typos in internal helpers
Alternate Designs
N/A
Possible Drawbacks
None. These are primarily bug fixes and documentation enhancements.
Verification Process
Ran the local development server and verified that the
theme.cssfont overrides are now correctly applied to the Collapsable headers.Verified that the Task List links are picking up the correct theme colors via the fixed var() call in
TaskListLabel.tsxRelease Notes
Fixed several CSS variables and styling typos to ensure theme consistency across all UI components.
Improved the main README with architectural and technical details to assist new contributors.