feat: theming, UI polish and dark mode integrations (#157)#190
Open
Vinyl-Davyl wants to merge 9 commits intoNetflix:masterfrom
Open
feat: theming, UI polish and dark mode integrations (#157)#190Vinyl-Davyl wants to merge 9 commits intoNetflix:masterfrom
Vinyl-Davyl wants to merge 9 commits intoNetflix:masterfrom
Conversation
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Description of the Change
This PR addresses the general implementation of the Dark Mode and several UI regressions and theme consistency issues. It focuses on ensuring parity between OS-level theme detection and manual theme toggling, while refining the visual style of tables, logs, inputs and more.
Key Changes
1. Dark Mode Integration, Theme Consistency & Explicit Resets
Metaflow UI is now fully themed for both light and dark modes. The implementation leverages the existing CSS variable architecture:
prefers-color-scheme).localStorage.[data-theme='light']reset block in theme.css. This ensures that when a user manually toggles to Light Mode on a machine with a Dark OS preference, all color primitives (text, backgrounds, inputs) are explicitly reset to their light-mode hex values rather than inheriting dark-mode variables.--code-bg,--input-text-color, and--table-cell-borderto the explicit[data-theme='dark']block to ensure a consistent experience across both "Auto" and "Manual" dark modes.2. UI Polish & Aesthetics to fit Development
1px solid rgba(255, 255, 255, 0.1)) in dark mode, matching a more modern, premium aesthetic.#f5f5f5) in light mode and a deep charcoal (#181818) in dark mode, providing better contrast and distinguishing logs from the main page background.2.375rem) precisely with the adjacent "Quick links" button to maintain a balanced header layout.Alternate Designs
Possible Drawbacks
Verification Results
The implementation has been verified for both Light/Dark modes and Auto/Manual toggling. Below are the key visual confirmations:
Related checks
The implementation has been verified for both Light/Dark modes and Auto/Manual toggling. Below are more key visual confirmations:
Related Issues
Closes the final set of UI polish requests for the Dark Mode integration in issue #157