feat: add code package download link to run header#193
Open
Aryan95614 wants to merge 1 commit intoNetflix:masterfrom
Open
feat: add code package download link to run header#193Aryan95614 wants to merge 1 commit intoNetflix:masterfrom
Aryan95614 wants to merge 1 commit intoNetflix:masterfrom
Conversation
When a run has code_package_url in its metadata, the run header now shows a "Download" link with the first 8 chars of the SHA for identification. The link opens in a new tab. Hidden when code_package_url metadata is not present, so no change for runs that don't have it. Fixes Netflix#72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a download link for the code package in the run detail header. When
code_package_urlis present in the run's metadata, a "Download" link appears with the first 8 characters of the SHA for identification. Opens in a new tab.Hidden when the metadata field is not present, so no visual change for runs without a code package.
Files changed
src/pages/Run/RunHeader.tsx-- add conditional header item + styled linkFixes #72.