feat: add pulse animation to running DAG nodes#194
Open
Aryan95614 wants to merge 1 commit intoNetflix:masterfrom
Open
feat: add pulse animation to running DAG nodes#194Aryan95614 wants to merge 1 commit intoNetflix:masterfrom
Aryan95614 wants to merge 1 commit intoNetflix:masterfrom
Conversation
Running steps in the DAG view now pulse with a subtle animation so users can tell at a glance which steps are actively executing. The pulse uses the existing warning color (yellow/orange) to match the running state border color. Steps in completed, failed, or unknown states render without animation as before. Partially addresses Netflix#89 (dynamic graph view) by making the static DAG more responsive to live execution state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running steps in the DAG view now pulse with a subtle box-shadow animation so users can see at a glance which steps are actively executing. Completed, failed, and unknown steps render without animation as before.
What changed
Added a CSS keyframe animation (
dag-pulse) toNormalIteminDAGContent.tsxthat activates whenstate === 'running'. Uses the existing warning color variable for consistency with the running-state border.Files changed
src/components/DAG/components/DAGContent.tsx-- pulse animation + conditional applicationPartially addresses #89.