fix: adjust padding in VirtualizedTimeline for fullscreen mode#195
Open
Ayuxh-Pratap wants to merge 1 commit intoNetflix:masterfrom
Open
fix: adjust padding in VirtualizedTimeline for fullscreen mode#195Ayuxh-Pratap wants to merge 1 commit intoNetflix:masterfrom
Ayuxh-Pratap wants to merge 1 commit intoNetflix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Description of the Change
Fixes an issue where floating labels in dropdown fields (e.g., "Mode", "Order by") were visually clipped in the fullscreen timeline view.
The issue occurred because the floating label uses a negative translate transform to move above the input field, while the fullscreen container applies
overflow: hidden, causing the label to be partially cut off.This change adds a small top padding to the fullscreen timeline container, ensuring sufficient space for the label to render correctly without modifying global input styles or layout behavior.
The Issue (FullView mode)
Fullscreen After Fix (Resolved)
Fullscreen Before Fix (Clipped Label)
Alternate Designs
Removing
overflow: hiddenfrom the fullscreen container→ Not chosen as it could introduce unintended layout and scrolling issues.
Modifying the global label transform (
--input-label-transform-active)→ Not chosen because it would affect all input fields across the application.
Using
overflow: visibleselectively→ Not chosen due to potential side effects with layout containment.
The selected approach (adding localized padding) is minimal, targeted, and avoids global impact.
Possible Drawbacks
Verification Process
Opened a flow run page:
http://localhost:3000/DemoFlow/2?direction=asc&group=true&order=startTime&statusTested in normal view:
Switched to fullscreen view:
Interacted with:
Confirmed:
Release Notes
Fixed an issue where dropdown labels were clipped in fullscreen timeline view.