Add first-class dark mode with token hardening and plugin iframe theme sync (resolves #157)#196
Open
Ayuxh-Pratap wants to merge 4 commits intoNetflix:masterfrom
Open
Add first-class dark mode with token hardening and plugin iframe theme sync (resolves #157)#196Ayuxh-Pratap wants to merge 4 commits intoNetflix:masterfrom
Ayuxh-Pratap wants to merge 4 commits intoNetflix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #157
Requirements for a pull request
Description of the Change
This PR implements dark mode in a phased, production-safe way across host UI and plugin iframes.
Theme foundation
light | dark) with persistence (localStoragekey:mf-theme).src/index.tsxto prevent initial light flash.[data-theme='dark'].Token hardening
Modal,Tooltip,DAGContent,RenderMetadata,TimelineRow/LineElement,PluginGroup.Plugin theme synchronization
MF_THEME_CHANGE).data-mf-plugin).ReadyToRender.settingswiththeme(in addition totimezone).Alternate Designs
ThemeProviderobject migration was considered but not chosen.data-theme+ token overrides is lower-risk and lower-churn.postMessagetargetOrigin was considered but not used as primary path.srcwhen available, with safe fallback.Possible Drawbacks
Verification Process
ReadLints) and fixed formatting/import-order issues.yarn buildRelease Notes
Added first-class dark mode support with persisted theme preference, tokenized UI styling for core views, and plugin iframe theme synchronization.