fix(debug): fix malformed log filename and persist HTTP warnings to IndexedDB (#181)#197
Open
rupeshca007 wants to merge 1 commit intoNetflix:masterfrom
Open
fix(debug): fix malformed log filename and persist HTTP warnings to IndexedDB (#181)#197rupeshca007 wants to merge 1 commit intoNetflix:masterfrom
rupeshca007 wants to merge 1 commit intoNetflix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #181.
Description
This PR resolves two related defects in the client-side debug logging infrastructure:
Bug 1 - Malformed log filename (debugdb.ts):
The getLogs() function had a stray } at the end of the template literal, producing filenames like logs-2025-01-01T00:00:00.000Z}.txt. Removed the extra }.
Bug 2 - HTTP warnings missing from debug log (errorlogger.ts):
logWarning() only called console.warn, never writing to the IndexedDB debug log via setLogItem. This meant downloaded crash reports were missing the most useful diagnostic entries. Fixed by importing setLogItem from debugdb and calling it inside logWarning to persist all warnings to the persistent log.
Changes
Verification