Skip to content

Fix broad exception handling in CLI step lookup and resume run-id validation #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuisJG8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix broad exception handling in CLI step lookup and resume run-id validation #3179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metaflow/cli_components/run_cmds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def resume(
# be non-integers to avoid any clashes. This condition ensures this.
try:
int(run_id)
except:
except (TypeError, ValueError):
pass
else:
raise CommandException("run-id %s cannot be an integer" % run_id)
Expand Down
2 changes: 1 addition & 1 deletion metaflow/cli_components/step_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def step(
func = None
try:
func = getattr(ctx.obj.flow, step_name)
except:
except AttributeError:
raise CommandException("Step *%s* doesn't exist." % step_name)
if not func.is_step:
raise CommandException("Function *%s* is not a step." % step_name)
Expand Down