Fix background scheduler branch completion#12033
Draft
flcl42 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
BlocksProcessedevent toIBranchProcessorand emit it fromBranchProcessorin afinallypath after branch cleanup.BackgroundTaskSchedulerto pause background tasks for the full non-sync branch-processing interval instead of resuming on the first per-blockBlockProcessedevent.Problems fixed
BlockProcessedevent even though later blocks in the same branch could still be processing.BlocksProcessingand then exited before a matchingBlockProcessed, the scheduler could keep a cancelled block-processing CTS and leave queued or future work paused/cancelled until another successful block happened to reset it.BlocksProcessingEventArgsobject identity for completion, so branch completion raised with fresh event args still restores normal scheduling.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
Draft PR for review.