Skip to content

Handle incompatible discovery fork IDs#12055

Draft
flcl42 wants to merge 176 commits into
fork-id-node-recordfrom
forkid-discovery
Draft

Handle incompatible discovery fork IDs#12055
flcl42 wants to merge 176 commits into
fork-id-node-recordfrom
forkid-discovery

Conversation

@flcl42

@flcl42 flcl42 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Defer discv4 peer admission while a refreshed ENR fork ID is required or already pending.
  • Remove discv4 discovery nodes when a refreshed signed same-node ENR fails fork-id validation.
  • Avoid publishing bare-node health updates from handled ENR responses before the refreshed ENR has been validated.
  • Add regression coverage for incompatible refreshed ENRs and pending ENR refreshes followed by sequence-less pings.

Types of changes

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Targeted discovery/fork-id regression coverage passed. The broader discovery project still has an unrelated E2E discovery failure on this branch.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

Remarks

None.

@flcl42 flcl42 changed the base branch from master to fork-id-node-record June 18, 2026 08:39
@github-actions github-actions Bot removed configuration dependencies Pull requests that update a dependency file labels Jun 18, 2026
@flcl42 flcl42 force-pushed the fork-id-node-record branch from 2528dfd to d0600d4 Compare June 23, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants