Build benchmarks in GitHub actions

[ElijahVlasov]

It's nice to have a dedicated step that builds benchmarks.

[v0-e]

--all-targets is cool too 😄

[maksimryndin]

@ElijahVlasov thanks for the contribution :)

What is the rationale of building benches without running them?

[ElijahVlasov]

@ElijahVlasov thanks for the contribution :)

What is the rationale of building benches without running them?

Well, it's definitely worth looking into things like https://github.com/marketplace/actions/continuous-benchmark.

For the time being, it's nice to see when benches fail to build, not to figure out why the clippy step's failed.

[v0-e]

lgtm!

[maksimryndin]

@ElijahVlasov thanks for the contribution :)
What is the rationale of building benches without running them?

Well, it's definitely worth looking into things like https://github.com/marketplace/actions/continuous-benchmark.

For the time being, it's nice to see when benches fail to build, not to figure out why the clippy step's failed.

Does cargo check --benches do the job? (it is more lightweight

@cupicmarko you've cooked some benchmark action? Can we use it?

[ElijahVlasov]

Does it make sense to remove

- name: Build
      run: cargo test --workspace --verbose --no-run

?

[v0-e]

Does it make sense to remove

Yeah 👍

[cupicmarko]

@cupicmarko you've cooked some benchmark action? Can we use it?

@maksimryndin yes, I can publish it as a github-action and we can try it on a real project.

[maksimryndin]

On the cargo build everything it may slowdown things without actual use in this job except tests.
We can use cargo check

[frozenspider]

On the cargo build everything it may slowdown things without actual use in this job except tests.
We can use cargo check

Doesn't cargo check --workspace --all-features --all-targets imply building everything as well?
The goal we're trying to achieve is to make sure no parts of the build is broken - including benchmarks that are not built during normal test run

[maksimryndin]

On the cargo build everything it may slowdown things without actual use in this job except tests.
We can use cargo check

Doesn't cargo check --workspace --all-features --all-targets imply building everything as well? The goal we're trying to achieve is to make sure no parts of the build is broken - including benchmarks that are not built during normal test run

that's what I've meant. To use a check command (with the proper arguments ofc)

[maksimryndin]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".