Conversation
README.md:219 already states FDL shut down completely on 25 August 2025, but two passages written later described it as "shutting down" — including one added in the same commit, so the file contradicted itself a hundred lines apart. Past tense is also the stronger argument: "every link it had ever minted stopped resolving" is the concrete outcome people are still dealing with, where the progressive tense reads like a warning about something that hasn't happened yet and dates the project to before it did.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two passages described Firebase Dynamic Links as "shutting down". It shut down on 25 August 2025 — over a year ago.
README.md:219already says so correctly, so the file contradicted itself about a hundred lines apart. One of the two wrong passages was added in #24, so this is cleanup of my own error.Past tense is also the stronger argument. "Every link it had ever minted stopped resolving" is a concrete outcome people are still dealing with; "is shutting down" reads as a warning about something that hasn't happened yet, and dates the project to before it did — a bad look right as the repo goes public.