Skip to content

Add Support for Webhooks#4

Open
cr0wst wants to merge 8 commits into
mainfrom
add-webhook-support
Open

Add Support for Webhooks#4
cr0wst wants to merge 8 commits into
mainfrom
add-webhook-support

Conversation

@cr0wst
Copy link
Copy Markdown

@cr0wst cr0wst commented Jun 21, 2019

This PR adds webhook controllers which publish events for things like incoming SMS.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 21, 2019

Codecov Report

Merging #4 into master will decrease coverage by 2.17%.
The diff coverage is 96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
- Coverage       100%   97.82%   -2.18%     
- Complexity       25       41      +16     
============================================
  Files             2        6       +4     
  Lines            33       46      +13     
  Branches          4        4              
============================================
+ Hits             33       45      +12     
- Misses            0        1       +1
Impacted Files Coverage Δ Complexity Δ
...in/com/nexmo/starter/NexmoCredentialsProperties.kt 100% <ø> (ø) 7 <0> (?)
...om/nexmo/starter/events/SmsMessageReceivedEvent.kt 100% <100%> (ø) 1 <1> (?)
...kotlin/com/nexmo/starter/NexmoAutoConfiguration.kt 100% <100%> (ø) 25 <14> (ø) ⬇️
.../starter/webhooks/NexmoWebhookAutoConfiguration.kt 100% <100%> (ø) 2 <2> (?)
...o/starter/webhooks/SmsMessageReceivedController.kt 100% <100%> (ø) 4 <4> (?)
...m/nexmo/starter/webhooks/NexmoWebhookProperties.kt 66.66% <66.66%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0d315...80948b0. Read the comment docs.

@cr0wst cr0wst added the WIP work in progress label Jun 21, 2019
@mheap mheap changed the base branch from master to main February 2, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants