Conversation
There was a problem hiding this comment.
Pull request overview
March package update for the Next2D TypeScript template, plus CI workflow wiring so publishing on main runs the lint workflow first.
Changes:
- Bump template devDependencies (Capacitor, ESLint, TypeScript-ESLint, etc.) in
template/package.json. - Bump package version to
4.0.1. - Add
lintas a prerequisite job forpublishand makelint.ymlreusable viaworkflow_call.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
template/package.json |
Updates devDependency versions for the template project. |
package.json |
Bumps published template package version to 4.0.1. |
.github/workflows/publish.yml |
Adds a reusable lint job dependency and expands job permissions. |
.github/workflows/lint.yml |
Adjusts triggers and allows reuse via workflow_call; removes some permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write |
There was a problem hiding this comment.
pull-requests: write is newly granted to the publish job, but this workflow only triggers on push to main and the steps shown don’t interact with PRs. Please drop this permission (or justify it with an actual PR-writing step) to avoid granting unnecessary write access.
Suggested change
| pull-requests: write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.