feat(APP-204): pre-cache DuckDB extensions, remove runtime download#22046
Merged
insomnious merged 5 commits intomasterfrom Apr 1, 2026
Merged
feat(APP-204): pre-cache DuckDB extensions, remove runtime download#22046insomnious merged 5 commits intomasterfrom
insomnious merged 5 commits intomasterfrom
Conversation
…ownload
- Download script: fix CJS compat (import.meta.dirname → __dirname), add
gzip decompression, correct @duckdb/node-api package path
- DuckDBSingleton: drop FORCE INSTALL over HTTPS; use extension_directory
config so LOAD level_pivot resolves from the pre-downloaded cache
- LevelPersist: pass getVortexPath("base")/duckdb-extensions as extensionDir
- InstallAssets.json: copy pre-downloaded extensions into out/ and dist/
- package.json: run download script in build:assets and dist:assets pipelines
- src/main/package.json: add postinstall to download extensions after pnpm install
halgari
force-pushed
the
halgari/duckdb-extension-caching
branch
from
e2fd139 to
3e296d2
Compare
Download now runs explicitly via build:assets and dist:assets in the root package.json.
…cess
DuckDB's C++ extension loader uses OS file I/O and cannot read from inside
an Electron ASAR archive. Add duckdb-extensions to asarUnpack so they land
in app.asar.unpacked/, and introduce getVortexPath("base_unpacked") so
LevelPersist always points DuckDB at the real filesystem path.
insomnious
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes APP-204.
Summary
scripts/download-duckdb-extensions.ts) fetches.duckdb_extension.gzfiles at install/build time and decompresses them intosrc/main/build/duckdb-extensions/{version}/{platform}/DuckDBSingleton: removedFORCE INSTALL ... FROM 'https://...'; setsextension_directorysoLOAD level_pivotresolves from the local cache — no network call at startupLevelPersist: passesgetVortexPath("base")/duckdb-extensionsas the extension directoryInstallAssets.json: copies pre-downloaded extensions intoout/anddist/postinstallinsrc/main/package.json: downloads extensions automatically afterpnpm installbuild:assets/dist:assets: download step prepended so CI and packaging always have fresh extensionsTest plan
pnpm installtriggers postinstall and downloads extensionspnpm run build:assetsskips download if already cached, copies toout/