feat(queue-stats): replace Content-ID column with per-row schedule#21
Merged
Conversation
The Settings "Top contents" table dropped its raw Content-ID column in
favour of a state-dependent Schedule column: rows below the attempt cap
show the earliest retry countdown ("Retry in 45m"), rows at the cap show
the cleanup countdown ("Cleanup in 23h") driven by the 24h
ExhaustedRetention TTL.
Both times are aggregated per content_id in the existing Top-Contents
SQL via two MIN(CASE…) expressions over LastFailedAt / LastAttemptedAt;
no schema change. The shared SQLite-DateTime parse was extracted into a
helper since it now runs three times.
ExhaustedRetention is bumped from private to internal so the stats
service can reference the same TTL the maintenance contributor enforces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content IDcolumn from the Settings → Refresh queue "Top contents" table; adds a state-dependent Schedule column instead.Retry in 45m/ "Versuch in 45m", grey); rows at the cap show the cleanup countdown (Cleanup in 23h/ "Löschung in 23h", yellow) derived from the existing 24hExhaustedRetentionTTL.content_idvia twoMIN(CASE…)expressions overlast_failed_at/last_attempted_atin the same Top-Contents query — no schema change. The triple-used SQLite-DateTime parse is extracted intoParseSqliteDateTimeUtc.RefreshQueueMaintenanceContributor.ExhaustedRetentionis promoted fromprivatetointernalso the stats service and the maintenance contributor share one source of truth for the TTL.queuestats.col.content_id; addsqueuestats.col.schedule+ fourqueuestats.schedule.*keys inStrings.resxandStrings.de.resx.Test plan
Debug|x64is clean (verified locally: 0 warnings, 0 errors).attempt_count < 10) shows "Versuch in *h *m" in grey and the countdown ticks between the 3 s snapshot refreshes.attempt_count < 10,LastFailedAt = NULL) shows "Versuch steht an" in grey.10/10shows "Löschung in *h *m" in yellow.