feat(ui): add NexusStatusNotice widget with Text/Tooltip/Both modes#19
Merged
Conversation
A reusable "something is going on in the background" cue that the
PlayerNexusTracker detail panel had been re-implementing twice — once
inline as a grey wrapped banner inside tab bodies, once as an inline
yellow hourglass with hover tooltip in the panel header. Same icon,
same loc key, same player-loaded guard; only the presentation differed.
The widget collapses both presentations into one call site by carrying
a mode enum:
- Text icon + wrapped text laid out as a block element. Grey by
default, matching the legacy LodestonePlaceholder wrap.
- Tooltip icon only; hover shows the tooltip. Yellow by default and
SameLine-friendly, matching the legacy NexusHint hourglass.
- Both icon + wrapped text AND a hover tooltip on the icon, with
optional separate tooltipText so a short banner can carry
a longer hover explainer.
Caller decides text + (optional) separate tooltipText, icon, color
override, and sameLine. Defaults track the existing palette (yellow
for Tooltip, grey otherwise) so the migrating call sites keep their
visual contract.
NexusHint is intentionally left in place — it is still the right tool
for one-off field-change / gender / FC-candidate hints. This widget
is the higher-level "named status" cue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable status-notice widget to
NexusKit.Ui.Widgetsthat collapses two parallel implementations downstream inPlayerNexusTrackerinto a single primitive.The detail panel was carrying two visually different cues that share the same loc key, the same icon, and the same activation guard:
LodestonePlaceholder.Draw).DrawLodestoneStatusBadge).NexusStatusNoticeprovides three modes covering both — and a third (Both) that combines them with an optional separate tooltip text for cases where the body cue is short but the hover explainer is long.Modes
TextImGuiColors.DalamudGreyTooltipImGuiColors.DalamudYellowBothImGuiColors.DalamudGreyDefaults track the existing palette so migrating call sites keep their visual contract.
What this is NOT
NexusHint.NexusHintstays the right tool for one-off field-change / gender / FC-candidate hints. This widget is the higher-level "named status" cue.Test plan
dotnet buildclean (Debug | x64), 0 warnings.