chore(logging): suppress Trace/Debug/Info in Release builds#20
Merged
Conversation
PluginLogger.IsEnabled now gates everything below Warning behind !DEBUG, so Release builds only forward Warning/Error/Critical to Dalamud's /xllog. Debug builds keep the full firehose. The PluginLogger is the single bridge between Microsoft.Extensions. Logging and IPluginLogSink, so gating IsEnabled is sufficient — no M.E.L filter rules can re-open the gate from the consumer side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginLogger.IsEnabledgates everything belowWarningbehind#if !DEBUG. Release builds now only forwardWarning/Error/Criticalto Dalamud's/xllog; Debug builds keep the full firehose.PluginLoggeris the single bridge betweenMicrosoft.Extensions.LoggingandIPluginLogSink, so this gate covers every log call regardless of category-level filter rules.Why
Release plugins were spamming
/xllogwith Verbose/Debug/Info noise. We want a quieter user-facing log without losing detail during local development.Test plan
/xllogstill shows Verbose/Debug/Info as before./xllogonly shows Warning and above; previously noisy Info paths (e.g. EF CoreDatabase.Command) are silent.LogWarningfrom app code still reaches/xllogin Release.