feat(ui): add IWindowManager.Invoke<T> for framework-thread window actions#22
Merged
Conversation
…tions Resolves a registered window and runs an action against it on Dalamud's framework thread (inline when already on it), so callers reaching in from a background thread (e.g. a chat-link handler whose work went async) don't have to marshal themselves. WindowManager pulls IFramework from the service provider and falls back to a direct call when none is registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
IWindowManager.Invoke<T>(Action<T>)— resolves a registered window and runs the action against it on Dalamud's framework thread (inline when already on it).Why
Callers that reach into a window from a background thread (e.g. a chat-link handler whose work went async) shouldn't each have to inject
IFrameworkand marshal manually. Centralizing this in the window manager keeps window mutations on the UI thread by construction.How
WindowManagerresolvesIFrameworkfrom the service provider and wrapsaction(w)inRunOnFrameworkThread; falls back to a direct call when no framework service is registered (headless hosts). Additive, backwards-compatible.