Fix oauth_token auth request to avoid MissingDroidguard error#8
Merged
Conversation
Most likely was A/B testing, but thank you for this patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google appears to have recently started enforcing the
MissingDroidguardcheck on theoauth_tokenendpoint. This error was initially triggered sporadically but now seems to be consistently enforced.This change fixes the issue by explicitly adding
droidguard_results=nullto the auth request. Including this parameter prevents the server from rejecting the request with theMissingDroidguarderror.My assumption is that the issue started appearing due to a gradual rollout of updates on Google's infrastructure. As their servers are updated incrementally to maintain availability, some requests likely began hitting updated nodes earlier than others, which explains the intermittent errors observed in previous weeks.