docs(adr-010): note the Docker tag has no v prefix - #28
Merged
Merged
Conversation
Confirmed against the real published image after v0.5.0's release: the
{{ .Version }} Docker tag renders as 0.5.0, not v0.5.0 -- caught by
trying the v-prefixed form first and getting a 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny follow-up: confirmed against the real published
v0.5.0image that the Docker tag itself is0.5.0, notv0.5.0— worth a line in the ADR since it's an easy thing to get wrong by analogy to the git tag (I did, briefly).