Draft
Conversation
Un1oR
reviewed
Apr 14, 2025
shermike
changed the title
Un1oR
reviewed
Apr 21, 2025
| @@ -80,10 +59,7 @@ func (as *AccountState) FetchRequestId() uint64 { | |||
| } | |||
|
|
|||
| func NewAccountStateReader(account *AccountState) *AccountStateReader { | |||
Contributor
There was a problem hiding this comment.
The account parameter is no longer used
| } | ||
|
|
||
| func (api *localShardApi) CallGetter( | ||
| func (api *localShardApiRo) CallGetter( |
Contributor
There was a problem hiding this comment.
Suggested change
| func (api *localShardApiRo) CallGetter( | |
| func (api *localShardApiRo) callGetter( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Proof Of Concept PR about enshrined tokens implemented in contracts.
The following was done:
TokenManagercontract control all tokens within one shard. It has a predefined address and is deployed on each shard.Relayeris a stub for messages via contracts. In this PR, it is necessary only for callingTokenManagercontract to handle tokens.RelayerIt already passes all tests from
multitoken_test.gofile.