Change keyboard hotkeys from arrow keys to WASD#271
Conversation
* "Claude PR Assistant workflow" * "Claude Code Review workflow"
301603f to
f6b6d51
Compare
f6b6d51 to
8552aea
Compare
Modify the workflow prompt to instruct Claude Code to post each code-related issue as a separate GitHub PR review comment instead of grouping all feedback into a single message. This makes reviews more actionable and allows developers to address issues individually. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
8552aea to
d708c47
Compare
Ensure Claude Code always runs PR preview step for every pull request, regardless of size, complexity, or any other criteria. This prevents any automatic skipping of the preview process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
d708c47 to
37b123a
Compare
Update the Claude Code review workflow prompt to explicitly instruct the use of gh api for creating inline review comments on specific code lines, rather than general PR comments. This provides developers with actionable feedback directly on the relevant code. Changes: - Add detailed gh api command syntax for inline comments - Specify requirements: full SHA, exact line numbers, side parameter - Clarify difference between gh api (inline) and gh pr comment (general) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
78942f2 to
dfc22df
Compare
Change 'PR preview' to 'PR review' throughout the critical rule for consistency and accuracy with the actual workflow behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dfc22df to
ca29246
Compare
Revert to simpler instructions for posting individual review comments, removing the detailed gh api command syntax. The simpler prompt is more flexible and lets Claude Code determine the best approach. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ca29246 to
3d07b14
Compare
3d07b14 to
8dfa217
Compare
8dfa217 to
9ca1a5e
Compare
- Update workflow to use local plugin marketplace instead of remote - Expand CLAUDE.md with path aliases, keyboard shortcuts, and more detailed architecture documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9ca1a5e to
489a98c
Compare
Switch from local plugin marketplace to the official claude-code repository. Remove unused local settings file. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
489a98c to
e7a73a2
Compare
Code Review - Issues FoundI found 2 critical bugs in this PR that will break the "next subtitle" functionality: Issue 1: Typo in key code (line 13)File: Reference: easysubs/src/utils/keyboardHandler.ts Lines 12 to 17 in 657f422 Issue 2: Typo in event type (line 15)File: Reference: easysubs/src/utils/keyboardHandler.ts Lines 12 to 17 in 657f422 Both typos must be fixed for the D key (next subtitle) hotkey to work. |
8461e15 to
54d4b26
Compare
Copy the code-review plugin from claude-code repository to use locally instead of fetching from remote marketplace. This gives more control over the plugin version and allows customization. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- ArrowLeft → KeyA (previous subtitle) - ArrowRight → KeyD (next subtitle) - ArrowDown → KeyS (replay current subtitle) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
f701d47 to
d87f18f
Compare
Code ReviewFound 2 critical bugs in the keyboard handler implementation that prevent the D key from working: Issue 1: Invalid keyboard event code (line 13)Bug: Location: Impact: The D key (next subtitle) functionality will be completely broken. Pressing D will never match CLAUDE.md Reference: Violates CLAUDE.md lines 66-70 which documents Suggested fix: if (event.code === "KeyD") {Issue 2: Invalid event type (line 15)Bug: Location: Impact: Even if the key code were correct, this condition will never be true. Valid keyboard event types are only CLAUDE.md Reference: Violates CLAUDE.md lines 66-70 which documents Suggested fix: if (event.type === "keydown") {Summary: Both bugs appear to be typos where extra characters ( |
Summary
Test plan
pnpm build