Draft
Add new Modal component with comprehensive DaisyUI modal patterns support#41
Conversation
Co-authored-by: Nittarab <6181406+Nittarab@users.noreply.github.com>
Co-authored-by: Nittarab <6181406+Nittarab@users.noreply.github.com>
Co-authored-by: Nittarab <6181406+Nittarab@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add new Modal component
Add new Modal component with comprehensive DaisyUI modal patterns support
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new Modal component for the DaisyComponents library, providing comprehensive support for all DaisyUI modal patterns and interactions.
Features
The Modal component supports three different modal implementation patterns:
Dialog Modal (HTML5 Dialog Element)
Checkbox Modal (Pure CSS Implementation)
Anchor Modal (Navigation-based)
Modal Features
backdrop_close: true)corner_close: true)modal_box_class: "w-11/12 max-w-5xl")responsive: true)position: :middle)Implementation Details
The Modal component follows established DaisyComponents patterns:
DaisyUI::BaseComponentbuild_argument()method for parameter validationactions/modal.rb→ class:DaisyUI::Modal)Testing & Preview Integration
PreviewTestConcernThe component generates HTML that exactly matches the existing DaisyUI modal fixture patterns, ensuring compatibility with the established design system.
Fixes #28.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
mise.runcurl -fsSL REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.