Skip to content

guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15#348857

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
leungbk:guile-ssh-update
Oct 25, 2024
Merged

guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15#348857
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
leungbk:guile-ssh-update

Conversation

@leungbk
Copy link
Copy Markdown
Member

@leungbk leungbk commented Oct 15, 2024


Fixes the build failure seen at https://hydra.nixos.org/build/273797767/nixlog/1

cc @ethancedwards8 @foo-dogsquared

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot requested a review from ethancedwards8 October 15, 2024 19:39
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 15, 2024
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4686

Comment thread pkgs/by-name/gu/guile-ssh/package.nix Outdated
Comment thread pkgs/by-name/gu/guile-ssh/package.nix Outdated
@leungbk leungbk changed the title guile-ssh: 0.16.3 -> unstable-2024-10-15 guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15 Oct 19, 2024
@phanirithvij phanirithvij added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 20, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 20, 2024
Copy link
Copy Markdown
Member

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guix builds and works as expected

@phanirithvij phanirithvij added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 22, 2024
@SuperSandro2000 SuperSandro2000 merged commit e826e3d into NixOS:master Oct 25, 2024
@GaetanLepage
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348857


x86_64-linux

✅ 2 packages built:
  • guile-ssh
  • guix

aarch64-linux

✅ 2 packages built:
  • guile-ssh
  • guix

x86_64-darwin

✅ 1 package built:
  • guile-ssh

aarch64-darwin

✅ 1 package built:
  • guile-ssh

@leungbk leungbk deleted the guile-ssh-update branch October 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants