python3Packages.llm-anthropic: init at 0.12#382108
Merged
minijackson merged 1 commit intoNixOS:masterfrom Feb 17, 2025
Merged
Conversation
ethancedwards8
suggested changes
Feb 15, 2025
Member
ethancedwards8
left a comment
There was a problem hiding this comment.
Otherwise LGTM. Thanks
Member
|
Closes NixOS#327800 Closes NixOS#372713 (Note: This is just NixOS#373495 upgraded to `0.12`. Seems like something happened with git/Github and my PR was automatically closed.) This is a plugin for the already packaged `llm` software. There exists 2 PRs related to this: - NixOS#327800: the original - NixOS#372713: forks the original and updates as it had no activity for multiple months As helpfully pointed out by @ShaddyDC (NixOS#372713 (comment)) this is now superseded by `llm-anthropic`, of which this is meant to package. (We also have other PRs that have been commited that add similr plugins at NixOS#359379 and NixOS#344746.)
18356e3 to
3f8e227
Compare
ethancedwards8
approved these changes
Feb 15, 2025
ShaddyDC
approved these changes
Feb 15, 2025
Contributor
There was a problem hiding this comment.
i haven't done a line by line comparison but assuming it's basically still the same as the previous mr this should be good, and nothing jumps out at me!
though it is a bit funny how many related mrs there are by now lol
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 382108
x86_64-linux
✅ 4 packages built:
- python312Packages.llm-anthropic
- python312Packages.llm-anthropic.dist
- python313Packages.llm-anthropic
- python313Packages.llm-anthropic.dist
ethancedwards8
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327800
Closes #372713
(Note: This is just #373495 upgraded to
0.12. Seems like something happened with git/Github and my PR was automatically closed.)This is a plugin for the already packaged
llmsoftware. There exists 2 PRs related to this:As helpfully pointed out by @ShaddyDC (#372713 (comment)) this is now superseded by
llm-anthropic, of which this is meant to package.(We also have other PRs that have been commited that add similr plugins at #359379 and #344746.)
CC: @ShaddyDC @Erethon
Tested with:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.