Skip to content

python3Packages.llm-anthropic: init at 0.12#382108

Merged
minijackson merged 1 commit intoNixOS:masterfrom
aos:aos/init-llm-anthropic-0.12
Feb 17, 2025
Merged

python3Packages.llm-anthropic: init at 0.12#382108
minijackson merged 1 commit intoNixOS:masterfrom
aos:aos/init-llm-anthropic-0.12

Conversation

@aos
Copy link
Copy Markdown
Member

@aos aos commented Feb 14, 2025

Closes #327800
Closes #372713

(Note: This is just #373495 upgraded to 0.12. Seems like something happened with git/Github and my PR was automatically closed.)

This is a plugin for the already packaged llm software. There exists 2 PRs related to this:

As helpfully pointed out by @ShaddyDC (#372713 (comment)) this is now superseded by llm-anthropic, of which this is meant to package.

(We also have other PRs that have been commited that add similr plugins at #359379 and #344746.)

CC: @ShaddyDC @Erethon

Tested with:

nix-shell -E 'with import (fetchTarball "https://github.com/NixOS/nixpkgs/archive/pull/382108/head.tar.gz") {}; mkShell { buildInputs = [ (python3.withPackages (ps: [ ps.llm ps.llm-anthropic ])) ]; }'

llm prompt --model claude-3.5-sonnet "give me some random text"

Here's some random text:

The purple elephant danced gracefully through fields of neon mushrooms while juggling watermelons and reciting ancient poetry.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 14, 2025
@nix-owners nix-owners Bot requested a review from natsukium February 14, 2025 18:15
@github-actions github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 14, 2025
Copy link
Copy Markdown
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks

Comment thread pkgs/development/python-modules/llm-anthropic/default.nix Outdated
@ethancedwards8
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382108


aarch64-darwin

✅ 4 packages built:
  • python312Packages.llm-anthropic
  • python312Packages.llm-anthropic.dist
  • python313Packages.llm-anthropic
  • python313Packages.llm-anthropic.dist

Closes NixOS#327800
Closes NixOS#372713

(Note: This is just NixOS#373495 upgraded to `0.12`. Seems like something
happened with git/Github and my PR was automatically closed.)

This is a plugin for the already packaged `llm` software. There exists 2 PRs related to this:
- NixOS#327800: the original
- NixOS#372713: forks the original and updates as it had no activity for multiple months

As helpfully pointed out by @ShaddyDC (NixOS#372713 (comment)) this is now superseded by `llm-anthropic`, of which this is meant to package.

(We also have other PRs that have been commited that add similr plugins at NixOS#359379 and NixOS#344746.)
@aos aos force-pushed the aos/init-llm-anthropic-0.12 branch from 18356e3 to 3f8e227 Compare February 15, 2025 02:55
Copy link
Copy Markdown
Contributor

@ShaddyDC ShaddyDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't done a line by line comparison but assuming it's basically still the same as the previous mr this should be good, and nothing jumps out at me!

though it is a bit funny how many related mrs there are by now lol

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382108


x86_64-linux

✅ 4 packages built:
  • python312Packages.llm-anthropic
  • python312Packages.llm-anthropic.dist
  • python313Packages.llm-anthropic
  • python313Packages.llm-anthropic.dist

@aos aos added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 15, 2025
@minijackson minijackson merged commit f53d7e5 into NixOS:master Feb 17, 2025
@aos aos deleted the aos/init-llm-anthropic-0.12 branch February 17, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants