Skip to content

keydb: drop #459727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Nov 13, 2025
Merged

keydb: drop #459727

Aleksanaa merged 1 commit into from
Nov 13, 2025

Conversation

@thunze
Copy link
Member

@thunze thunze commented Nov 8, 2025 •
edited
Loading

The keydb package is broken on master, vulnerable, and upstream's last release was in October 2023.

Hydra: https://hydra.nixos.org/build/311470939/nixlog/2
ZHF: #457852

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 8, 2025
emilylange
emilylange requested changes Nov 8, 2025
View reviewed changes
Copy link
Member

@emilylange emilylange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing, other than that, LGTM :)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 8, 2025
@thunze
keydb: drop
850e8a2 
The keydb package is broken [1], vulnerable [2], and upstream's
last release was in October 2023 [3].

[1] https://hydra.nixos.org/build/311470939/nixlog/2
[2] Snapchat/KeyDB#918
[3] https://github.com/Snapchat/KeyDB/releases
@PlasmaPower PlasmaPower added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 13, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 13, 2025
Merged via the queue into NixOS:master with commit a0344ff Nov 13, 2025
27 of 31 checks passed
@thunze thunze deleted the drop-keydb branch November 13, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@emilylange emilylange emilylange approved these changes

@Conni2461 Conni2461 Awaiting requested review from Conni2461

@dasJ dasJ Awaiting requested review from dasJ

@helsinki-Jo helsinki-Jo Awaiting requested review from helsinki-Jo

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thunze @Aleksanaa @emilylange @PlasmaPower