Skip to content

nextcloud: direct pre-signed download link - #498820

Closed
ser wants to merge 1 commit into
NixOS:masterfrom
ser:nextcloud
Closed

nextcloud: direct pre-signed download link#498820
ser wants to merge 1 commit into
NixOS:masterfrom
ser:nextcloud

Conversation

@ser

@ser ser commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR extends S3 configuration with a use_presigned_url introduced in Nextcloud 33 with nextcloud/server#54436

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 11, 2026
@ser
ser force-pushed the nextcloud branch 2 times, most recently from 10b57be to 3094514 Compare March 11, 2026 11:59
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 11, 2026
@ser

ser commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

please review.

@bachp

@britter

@Ma27

@provokateurin

@provokateurin

provokateurin commented Mar 11, 2026

Copy link
Copy Markdown
Member

I think adding an assertion for the case where this is enabled on versions before 33 makes sense.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Mar 11, 2026
@ser

ser commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

I think adding an assertion for the case where this is enabled on versions before 33 makes sense.

Added! Thanks.

provokateurin
provokateurin reviewed Mar 11, 2026
View reviewed changes
Comment thread nixos/modules/services/web-apps/nextcloud.nix Outdated
@provokateurin
provokateurin requested a review from Ma27 March 12, 2026 13:47
Ma27
Ma27 reviewed Mar 13, 2026
View reviewed changes

@Ma27 Ma27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@provokateurin how hard would it be to extend the VM test to make sure it's properly serving pre-signed files? I imagine you'd have to upload a file and obtain a download link?

If it's reasonably doable, I'd really like to see test-coveratge for it.

@ser

ser commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

If it's reasonably doable, I'd really like to see test-coveratge for it.

the verification procedure is described here:
nextcloud/server#54436 (comment)

@provokateurin

provokateurin commented Mar 13, 2026

Copy link
Copy Markdown
Member

how hard would it be to extend the VM test to make sure it's properly serving pre-signed files? I imagine you'd have to upload a file and obtain a download link?

Should be easy, the link is just a WebDAV prop that can be queried.

@ser

ser commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Despite of installing a patched version of Nextcloud with this PR and enabling the presigned urls, I am unable to see them, unfortunately.

I am getting empty values: <oc:downloadURL></oc:downloadURL><nc:download-url-expiration></nc:download-url-expiration>

@Ma27

Ma27 commented Mar 20, 2026

Copy link
Copy Markdown
Member

Anything interesting in the error logs?

@ser

ser commented Mar 22, 2026

Copy link
Copy Markdown
Contributor Author

Anything interesting in the error logs?

No, nothing special. I set the loglevel to 0 to be sure, but there is nothing suspicious, the request is served normally, the file is found correctly.

@ser

ser commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

I have installed a Nextcloud docker and I get the same issue, so it's not related to the NixOS packaging. I am investigating it further for a likely Nextcloud bug.

@nixpkgs-ci nixpkgs-ci Bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 5, 2026
@ser

ser commented Apr 5, 2026

Copy link
Copy Markdown
Contributor Author

I filed nextcloud/server#59249 but it does not seem to a prority for the nextcloud S3 team

@ser

ser commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The bug was fixed today, I assume it will be fixed in version 35 of nextcloud.

Edit: Oh no, it is backported to 33 and 34! I will run tests soon to confirm if it works.

@provokateurin it would be cool if you could review it to backport
nextcloud/server#63456

Ma27
Ma27 reviewed Aug 21, 2026
View reviewed changes
Comment thread nixos/modules/services/web-apps/nextcloud.nix
'use_ssl' => ${lib.boolToString s3.useSsl},
${lib.optionalString (s3.region != null) "'region' => '${s3.region}',"}
'use_path_style' => ${lib.boolToString s3.usePathStyle},
'use_presigned_url' => ${lib.boolToString s3.usePresignedUrl},

@Ma27 Ma27 Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisiting this, what was the reason we're not setting this settings?

@ser ser Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new nextcloud feature. I mean, it will be when it starts working.

@Ma27 Ma27 Aug 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate? I don't follow how this relates to my question, sorry.

@ser ser Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I do not understand your question, then.

@bachp bachp Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ma27 Are you asking why not just set use_presigned_url via settings instead of adding a new option?

@ser

ser commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

No rush guys, this one liner is being deliberated for only 171 days. We have plenty of time to take a really good decision which analyses full spectrum of potential effects in micro- and macro- scale.

@Ma27

Ma27 commented Aug 29, 2026

Copy link
Copy Markdown
Member

Fine, making a decision then. It's Won't do.
As I pointed out, you can do this via settings.

We've been literally waiting for you to answer and you come with sarcasm about things not moving? 🤡

@Ma27 Ma27 closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bachp bachp bachp left review comments
@Ma27 Ma27 Ma27 left review comments
+1 more reviewer
@provokateurin provokateurin provokateurin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ser @provokateurin @Ma27 @bachp