deno: de-vendor lcms2, zstd, sqlite, libz by Mynacol · Pull Request #545634 · NixOS/nixpkgs

Mynacol · 2026-07-25T15:10:42Z

These are the libraries we can de-vendor from deno (not rusty-v8). With this, we match Arch Linux in the de-vendoring effort and also de-vendor libz.

Things done

Mynacol · 2026-07-27T13:18:15Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 545634
Commit: 758cb24c4c37a88bf19aa2fa627e08a0f9a7c3eb

`x86_64-linux`

❌ 2 packages failed to build:

castero
minitube

✅ 133 packages built:

adl
ani-cli
auto-editor
bluebubbles
catt
celluloid
cine
clapper
clapper-enhancers
cliamp
cplay-ng
curseradio
delfin
deno
dmlive
dra-cla
era
ff2mpv
ff2mpv-go
gallery-dl
gleam
gonic
gophertube
gpodder
gtk-pipe-viewer
haruna
hydrus
hypnotix
invidtui
jellyfin-mpv-shim
jellyfin-tui
jellytui
jftui
kdePackages.audiotube
kdePackages.kalarm
kdePackages.plasmatube
kikoplay
klipperscreen
kodiPackages.sendtokodi
kopuz
linux-wallpaperengine
liquidsoap
lollypop
losange
mealie
memento
mkchromecast
monophony
moodle-dl
mopidy-youtube (mopidyPackages.mopidy-youtube)
mov-cli
mpc-qt
mpv
mpv-handler
mpvScripts.mpv-playlistmanager
mpvpaper
music-assistant
parabolic
parrot
persepolis
photoqt
pinchflat
pipe-viewer
pipeline
plex-mpv-shim
previewqt
python313Packages.beets-ytimport
python313Packages.bgutil-ytdlp-pot-provider
python313Packages.mpv
python313Packages.tubeup
python313Packages.yark
python313Packages.yt-dlp
python314Packages.beets-ytimport
python314Packages.bgutil-ytdlp-pot-provider
python314Packages.mpv
python314Packages.tubeup
python314Packages.yark
python314Packages.yt-dlp
qimgv
qmplay2 (qmplay2-qt6)
qmplay2-qt5
qtgreet
quarto
quartoMinimal
radiance-vj
radio-cli
radioboat
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
scdl
sharedown
shira
simple-live-app
somafm-cli
spotdl
stremio-linux-shell
subtitleedit
svp
switchfin
szurubooru.server
tartube-yt-dlp
tests.home-assistant-components.media_extractor
tomato-c
tuba
varia
vidcutter
video-downloader
vimPlugins.ddc-filter-matcher_head
vimPlugins.ddc-filter-sorter_rank
vimPlugins.ddc-fuzzy
vimPlugins.ddc-source-around
vimPlugins.ddc-source-file
vimPlugins.ddc-source-lsp
vimPlugins.ddc-ui-native
vimPlugins.ddc-ui-pum
vimPlugins.ddc-vim
vimPlugins.denops-vim
vimPlugins.peek-nvim
vimPlugins.vim-pluto
vrcvideocacher
windmill
wtwitch
yewtube
youtube-tui
yt-dlp
ytcc
ytdl-sub
ytdownloader
ytfzf
ytmdl
ytui-music

castero

      ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/build/source/castero/menus/episodemenu.py", line 100, in _request_source_episodes
      self.display()
      ~~~~~~~~~~~~^^
    File "/build/source/castero/menu.py", line 169, in display
      items = self._items
              ^^^^^^^^^^^
    File "/build/source/castero/menus/episodemenu.py", line 35, in _items
      "attr": curses.color_pair(5) if episode.played else curses.A_NORMAL,
              ~~~~~~~~~~~~~~~~~^^^
  _curses.error: must call initscr() first
Enable tracemalloc to get traceback where the object was allocated.

See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

warnings.warn(pytest.PytestUnhandledThreadExceptionWarning(msg))
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

FAILED tests/test_menu_episode.py::test_menu_episode_items - assert {'attr': <MagicMock name='color_pair()' id='140737287940016'>, 'tags...

========== 1 failed, 226 passed, 7 deselected, 65 warnings in 18.61s ===========

minitube

                 from src/ytregions.h:24,
                 from src/ytregions.cpp:21:
/nix/store/pnzq8phvychvwpf15zphdhi367gy87d8-qtbase-6.11.1/include/QtGui/qguiapplication.h:161:89: note: declared here
  161 |     QT_DEPRECATED_VERSION_X_6_0("Handle QEvent::ApplicationPaletteChange instead") void paletteChanged(const QPalette &pal);
      |                                                                                         ^~~~~~~~~~~~~~
lib/qt-reusable-widgets/iconutils.h: In static member function 'static void IconUtils::setIcon(T*, const char*)':
lib/qt-reusable-widgets/iconutils.h:23:46: warning: 'void QGuiApplication::paletteChanged(const QPalette&)' is deprecated: Handle QEvent::ApplicationPaletteChange instead [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
   23 |         obj->connect(qApp, &QGuiApplication::paletteChanged, obj, setObjIcon);
      |                                              ^~~~~~~~~~~~~~
/nix/store/pnzq8phvychvwpf15zphdhi367gy87d8-qtbase-6.11.1/include/QtGui/qguiapplication.h:161:89: note: declared here
  161 |     QT_DEPRECATED_VERSION_X_6_0("Handle QEvent::ApplicationPaletteChange instead") void paletteChanged(const QPalette &pal);
      |                                                                                         ^~~~~~~~~~~~~~
src/standardfeedsview.cpp: In member function 'virtual void StandardFeedsView::showEvent(QShowEvent*)':
src/standardfeedsview.cpp:174:47: warning: unused parameter 'event' [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wno-unused-parameter-Wunused-parameter8;;]
  174 | void StandardFeedsView::showEvent(QShowEvent *event) {
      |                                   ~~~~~~~~~~~~^~~~~
src/standardfeedsview.cpp: In member function 'virtual void StandardFeedsView::hideEvent(QHideEvent*)':
src/standardfeedsview.cpp:184:47: warning: unused parameter 'event' [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wno-unused-parameter-Wunused-parameter8;;]
  184 | void StandardFeedsView::hideEvent(QHideEvent *event) {
      |                                   ~~~~~~~~~~~~^~~~~

`aarch64-darwin`

⏩ 2 packages marked as broken and skipped:

mpc-qt
music-assistant

❌ 7 packages failed to build:

hydrus
previewqt
python313Packages.mpv
python314Packages.mpv
rstudio
rstudioWrapper
switchfin

✅ 78 packages built:

ani-cli
auto-editor
catt
cliamp
cplay-ng
curseradio
deno
dmlive
dra-cla
era
ff2mpv
ff2mpv-go
gallery-dl
gleam
gonic
gophertube
gpodder
gtk-pipe-viewer
invidtui
jellyfin-tui
jellytui
jftui
kodiPackages.sendtokodi
mealie
mkchromecast
moodle-dl
mopidy-youtube (mopidyPackages.mopidy-youtube)
mov-cli
mpv
mpvScripts.mpv-playlistmanager
parrot
persepolis
pinchflat
pipe-viewer
python313Packages.beets-ytimport
python313Packages.bgutil-ytdlp-pot-provider
python313Packages.tubeup
python313Packages.yark
python313Packages.yt-dlp
python314Packages.beets-ytimport
python314Packages.bgutil-ytdlp-pot-provider
python314Packages.tubeup
python314Packages.yark
python314Packages.yt-dlp
quarto
quartoMinimal
radio-cli
radioboat
scdl
shira
somafm-cli
spotdl
subtitleedit
szurubooru.server
tomato-c
video-downloader
vimPlugins.ddc-filter-matcher_head
vimPlugins.ddc-filter-sorter_rank
vimPlugins.ddc-fuzzy
vimPlugins.ddc-source-around
vimPlugins.ddc-source-file
vimPlugins.ddc-source-lsp
vimPlugins.ddc-ui-native
vimPlugins.ddc-ui-pum
vimPlugins.ddc-vim
vimPlugins.denops-vim
vimPlugins.peek-nvim
vimPlugins.vim-pluto
wtwitch
yewtube
youtube-tui
yt-dlp
ytcc
ytdl-sub
ytdownloader
ytfzf
ytmdl
ytui-music

Error logs: `aarch64-darwin`

python313Packages.mpv

FAILED tests/test_mpv.py::TestStreams::test_custom_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_bytes - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_context - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_forward - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_log_handler - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_negative - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_positive - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_async_command - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_loadfile_with_subtitles - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_instance_method_property_observer - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_unobserve_property_runtime_error - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
================= 40 failed, 4 passed, 3 deselected in 19.76s ==================

python314Packages.mpv

FAILED tests/test_mpv.py::TestStreams::test_custom_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_bytes - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_context - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_forward - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_log_handler - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_negative - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_positive - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_async_command - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_loadfile_with_subtitles - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_instance_method_property_observer - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_unobserve_property_runtime_error - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
================= 40 failed, 4 passed, 3 deselected in 24.37s ==================

rstudio

make[1]: *** [CMakeFiles/Makefile2:1527: src/cpp/core/CMakeFiles/rstudio-core-tests.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/RSessionState.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/RSession.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/RStdCallbacks.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/RSuspend.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsDevice.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsErrorCategory.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsPlot.cpp.o
[ 63%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsPlotManipulator.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsPlotManipulatorManager.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsPlotManager.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsUtils.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsDevDesc.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RGraphicsHandler.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/graphics/RShadowPngGraphicsHandler.cpp.o
[ 64%] Building CXX object src/cpp/r/CMakeFiles/rstudio-r.dir/session/REmbeddedPosix.cpp.o
[ 64%] Linking CXX static library librstudio-r.a
[ 64%] Built target rstudio-r
make: *** [Makefile:156: all] Error 2

switchfin

[ 94%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/recycling_grid.cpp.o
[ 95%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/recyling_video.cpp.o
1 warning generated.
[ 95%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/search_list.cpp.o
[ 96%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/selector_cell.cpp.o
[ 97%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/svg_image.cpp.o
[ 97%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/text_box.cpp.o
[ 98%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_card.cpp.o
1 warning generated.
[ 98%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_profile.cpp.o
[ 99%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_progress_slider.cpp.o
[ 99%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_source.cpp.o
[100%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_view.cpp.o
Copying OS X content Switchfin.app/Contents/Resources/app.icns
[100%] Linking CXX executable Switchfin.app/Contents/MacOS/Switchfin
ld: library not found for -lstdc++fs
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/Switchfin.dir/build.make:1251: Switchfin.app/Contents/MacOS/Switchfin] Error 1
make[1]: *** [CMakeFiles/Makefile2:238: CMakeFiles/Switchfin.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Mynacol · 2026-07-27T15:18:36Z

We can also remove the __vendored_zlib_ng build feature and properly de-vendor zlib.

06kellyjac · 2026-07-27T15:44:26Z

Nice

We can also remove the __vendored_zlib_ng build feature and properly de-vendor zlib.

As in, you'll add that to this PR?

Mynacol · 2026-07-27T16:32:25Z

We can also remove the __vendored_zlib_ng build feature and properly de-vendor zlib.

As in, you'll add that to this PR?

Yes. I didn't have this on my radar until today and want to better understand what's happening regarding zlib before committing it.

Mynacol · 2026-07-28T16:08:05Z

When removing the __vendored_zlib_ng build feature, the binary is indeed slightly smaller. I also tried to add the LIBZ_SYS_STATIC=0 environment variable (see rust-lang/libz-sys#252), but this didn't further decrease the binary size.
I have no definite proof, but I think there is no statically linked zlib remaining.

Mynacol · 2026-07-28T20:44:39Z

The updated nixpkgs-review also looks good. IMO this is good enough and we can merge it.

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 545634
Commit: c5c5d1c84763a3b04576eb7d107266e228729126

`x86_64-linux`

❌ 1 package failed to build:

minitube

✅ 134 packages built:

adl
ani-cli
auto-editor
bluebubbles
castero
catt
celluloid
cine
clapper
clapper-enhancers
cliamp
cplay-ng
curseradio
delfin
deno
dmlive
dra-cla
era
ff2mpv
ff2mpv-go
gallery-dl
gleam
gonic
gophertube
gpodder
gtk-pipe-viewer
haruna
hydrus
hypnotix
invidtui
jellyfin-mpv-shim
jellyfin-tui
jellytui
jftui
kdePackages.audiotube
kdePackages.kalarm
kdePackages.plasmatube
kikoplay
klipperscreen
kodiPackages.sendtokodi
kopuz
linux-wallpaperengine
liquidsoap
lollypop
losange
mealie
memento
mkchromecast
monophony
moodle-dl
mopidy-youtube (mopidyPackages.mopidy-youtube)
mov-cli
mpc-qt
mpv
mpv-handler
mpvScripts.mpv-playlistmanager
mpvpaper
music-assistant
parabolic
parrot
persepolis
photoqt
pinchflat
pipe-viewer
pipeline
plex-mpv-shim
previewqt
python313Packages.beets-ytimport
python313Packages.bgutil-ytdlp-pot-provider
python313Packages.mpv
python313Packages.tubeup
python313Packages.yark
python313Packages.yt-dlp
python314Packages.beets-ytimport
python314Packages.bgutil-ytdlp-pot-provider
python314Packages.mpv
python314Packages.tubeup
python314Packages.yark
python314Packages.yt-dlp
qimgv
qmplay2 (qmplay2-qt6)
qmplay2-qt5
qtgreet
quarto
quartoMinimal
radiance-vj
radio-cli
radioboat
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
scdl
sharedown
shira
simple-live-app
somafm-cli
spotdl
stremio-linux-shell
subtitleedit
svp
switchfin
szurubooru.server
tartube-yt-dlp
tests.home-assistant-components.media_extractor
tomato-c
tuba
varia
vidcutter
video-downloader
vimPlugins.ddc-filter-matcher_head
vimPlugins.ddc-filter-sorter_rank
vimPlugins.ddc-fuzzy
vimPlugins.ddc-source-around
vimPlugins.ddc-source-file
vimPlugins.ddc-source-lsp
vimPlugins.ddc-ui-native
vimPlugins.ddc-ui-pum
vimPlugins.ddc-vim
vimPlugins.denops-vim
vimPlugins.peek-nvim
vimPlugins.vim-pluto
vrcvideocacher
windmill
wtwitch
yewtube
youtube-tui
yt-dlp
ytcc
ytdl-sub
ytdownloader
ytfzf
ytmdl
ytui-music

minitube

lib/qt-reusable-widgets/iconutils.h:23:46: warning: 'void QGuiApplication::paletteChanged(const QPalette&)' is deprecated: Handle QEvent::ApplicationPaletteChange instead [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
   23 |         obj->connect(qApp, &QGuiApplication::paletteChanged, obj, setObjIcon);
      |                             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
/nix/store/pnzq8phvychvwpf15zphdhi367gy87d8-qtbase-6.11.1/include/QtGui/qguiapplication.h:161:89: note: declared here
  161 |     QT_DEPRECATED_VERSION_X_6_0("Handle QEvent::ApplicationPaletteChange instead") void paletteChanged(const QPalette &pal);
      |                                                                                         ^~~~~~~~~~~~~~
lib/qt-reusable-widgets/iconutils.h:23:28: warning: 'void QGuiApplication::paletteChanged(const QPalette&)' is deprecated: Handle QEvent::ApplicationPaletteChange instead [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
   23 |         obj->connect(qApp, &QGuiApplication::paletteChanged, obj, setObjIcon);
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/nix/store/pnzq8phvychvwpf15zphdhi367gy87d8-qtbase-6.11.1/include/QtGui/qguiapplication.h:161:89: note: declared here
  161 |     QT_DEPRECATED_VERSION_X_6_0("Handle QEvent::ApplicationPaletteChange instead") void paletteChanged(const QPalette &pal);
      |                                                                                         ^~~~~~~~~~~~~~
src/standardfeedsview.cpp: In member function 'virtual void StandardFeedsView::showEvent(QShowEvent*)':
src/standardfeedsview.cpp:174:47: warning: unused parameter 'event' [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wno-unused-parameter-Wunused-parameter8;;]
  174 | void StandardFeedsView::showEvent(QShowEvent *event) {
      |                                   ~~~~~~~~~~~~^~~~~
src/standardfeedsview.cpp: In member function 'virtual void StandardFeedsView::hideEvent(QHideEvent*)':
src/standardfeedsview.cpp:184:47: warning: unused parameter 'event' [8;;https://gcc.gnu.org/onlinedocs/gcc-15.3.0/gcc/Warning-Options.html#index-Wno-unused-parameter-Wunused-parameter8;;]
  184 | void StandardFeedsView::hideEvent(QHideEvent *event) {
      |                                   ~~~~~~~~~~~~^~~~~

`aarch64-darwin`

⏩ 2 packages marked as broken and skipped:

mpc-qt
music-assistant

❌ 5 packages failed to build:

hydrus
previewqt
python313Packages.mpv
python314Packages.mpv
switchfin

✅ 80 packages built:

ani-cli
auto-editor
catt
cliamp
cplay-ng
curseradio
deno
dmlive
dra-cla
era
ff2mpv
ff2mpv-go
gallery-dl
gleam
gonic
gophertube
gpodder
gtk-pipe-viewer
invidtui
jellyfin-tui
jellytui
jftui
kodiPackages.sendtokodi
mealie
mkchromecast
moodle-dl
mopidy-youtube (mopidyPackages.mopidy-youtube)
mov-cli
mpv
mpvScripts.mpv-playlistmanager
parrot
persepolis
pinchflat
pipe-viewer
python313Packages.beets-ytimport
python313Packages.bgutil-ytdlp-pot-provider
python313Packages.tubeup
python313Packages.yark
python313Packages.yt-dlp
python314Packages.beets-ytimport
python314Packages.bgutil-ytdlp-pot-provider
python314Packages.tubeup
python314Packages.yark
python314Packages.yt-dlp
quarto
quartoMinimal
radio-cli
radioboat
rstudio
rstudioWrapper
scdl
shira
somafm-cli
spotdl
subtitleedit
szurubooru.server
tomato-c
video-downloader
vimPlugins.ddc-filter-matcher_head
vimPlugins.ddc-filter-sorter_rank
vimPlugins.ddc-fuzzy
vimPlugins.ddc-source-around
vimPlugins.ddc-source-file
vimPlugins.ddc-source-lsp
vimPlugins.ddc-ui-native
vimPlugins.ddc-ui-pum
vimPlugins.ddc-vim
vimPlugins.denops-vim
vimPlugins.peek-nvim
vimPlugins.vim-pluto
wtwitch
yewtube
youtube-tui
yt-dlp
ytcc
ytdl-sub
ytdownloader
ytfzf
ytmdl
ytui-music

Error logs: `aarch64-darwin`

python313Packages.mpv

FAILED tests/test_mpv.py::TestStreams::test_custom_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_bytes - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_context - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_forward - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_log_handler - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_negative - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_positive - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_async_command - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_loadfile_with_subtitles - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_instance_method_property_observer - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_unobserve_property_runtime_error - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
================= 40 failed, 4 passed, 3 deselected in 16.29s ==================

python314Packages.mpv

FAILED tests/test_mpv.py::TestStreams::test_custom_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_bytes - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_play_context - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_python_stream_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_exception - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestStreams::test_stream_open_forward - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_log_handler - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_event_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_negative - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_positive - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_property_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::TestLifecycle::test_wait_for_shutdown - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_async_command - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::CommandTests::test_loadfile_with_subtitles - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_instance_method_property_observer - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
FAILED tests/test_mpv.py::RegressionTests::test_unobserve_property_runtime_error - FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'
================= 40 failed, 4 passed, 3 deselected in 15.05s ==================

switchfin

[ 94%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/recycling_grid.cpp.o
[ 95%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/recyling_video.cpp.o
1 warning generated.
[ 95%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/search_list.cpp.o
[ 96%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/selector_cell.cpp.o
[ 97%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/svg_image.cpp.o
[ 97%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/text_box.cpp.o
[ 98%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_card.cpp.o
1 warning generated.
[ 98%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_profile.cpp.o
[ 99%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_progress_slider.cpp.o
[ 99%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_source.cpp.o
[100%] Building CXX object CMakeFiles/Switchfin.dir/app/src/view/video_view.cpp.o
Copying OS X content Switchfin.app/Contents/Resources/app.icns
[100%] Linking CXX executable Switchfin.app/Contents/MacOS/Switchfin
ld: library not found for -lstdc++fs
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/Switchfin.dir/build.make:1251: Switchfin.app/Contents/MacOS/Switchfin] Error 1
make[1]: *** [CMakeFiles/Makefile2:238: CMakeFiles/Switchfin.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

06kellyjac · 2026-07-29T16:18:22Z

Nice, what's the size difference out of interest?

Mynacol · 2026-08-01T16:36:51Z

Nice, what's the size difference out of interest?

In total, this PR reduces the size by slightly more than 2 MB. Just the libz library clocks in at maybe 100 KB or so. (all on x86_64-linux)
https://hydra.nixos.org/job/nixpkgs/unstable/deno.x86_64-linux

Mynacol added 3 commits July 25, 2026 14:05

deno: de-vendor sqlite

1ca2efe

deno: de-vendor zstd

7aa5f00

deno: de-vendor lcms2

758cb24

Mynacol marked this pull request as ready for review July 27, 2026 13:18

nixpkgs-ci Bot requested review from 06kellyjac, ap-1 and ofalvai July 27, 2026 14:10

deno: de-vendor zlib

c5c5d1c

Mynacol changed the title ~~deno: de-vendor lcms2, zstd, sqlite~~ deno: de-vendor lcms2, zstd, sqlite, libz Jul 28, 2026

06kellyjac approved these changes Jul 29, 2026

View reviewed changes

06kellyjac added this pull request to the merge queue Jul 29, 2026

Merged via the queue into NixOS:master with commit 003362c Jul 29, 2026
28 checks passed

Mynacol deleted the deno-devendor branch August 1, 2026 16:31

Navigation Menu

Uh oh!

Uh oh!

deno: de-vendor lcms2, zstd, sqlite, libz - #545634

deno: de-vendor lcms2, zstd, sqlite, libz#545634
06kellyjac merged 4 commits into
NixOS:masterfrom
Mynacol:deno-devendor

Mynacol commented Jul 25, 2026 •

edited

Loading

Uh oh!

Mynacol commented Jul 27, 2026

Uh oh!

Mynacol commented Jul 27, 2026

Uh oh!

06kellyjac commented Jul 27, 2026

Uh oh!

Mynacol commented Jul 27, 2026

Uh oh!

Mynacol commented Jul 28, 2026

Uh oh!

Mynacol commented Jul 28, 2026

Uh oh!

06kellyjac commented Jul 29, 2026

Uh oh!

Uh oh!

Mynacol commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Mynacol commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Mynacol commented Jul 27, 2026

nixpkgs-review result

x86_64-linux

aarch64-darwin

Uh oh!

Mynacol commented Jul 27, 2026

Uh oh!

06kellyjac commented Jul 27, 2026

Uh oh!

Mynacol commented Jul 27, 2026

Uh oh!

Mynacol commented Jul 28, 2026

Uh oh!

Mynacol commented Jul 28, 2026

nixpkgs-review result

x86_64-linux

aarch64-darwin

Uh oh!

06kellyjac commented Jul 29, 2026

Uh oh!

Uh oh!

Mynacol commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Mynacol commented Jul 25, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-darwin`