Skip to content

rot8: 1.0.0 -> 1.0.1 - #551258

Merged
Sigmanificient merged 1 commit into
NixOS:masterfrom
kurnevsky:rot8-bump
Aug 15, 2026
Merged

rot8: 1.0.0 -> 1.0.1#551258
Sigmanificient merged 1 commit into
NixOS:masterfrom
kurnevsky:rot8-bump

Conversation

@kurnevsky

@kurnevsky kurnevsky commented Aug 10, 2026

Copy link
Copy Markdown
Member

rot8 version update. Fixes rotation on pinenote.

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested a review from Smona August 10, 2026 20:39
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2026
@kurnevsky

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 551258
Commit: 4f06ece64bde48415383b22accf19f3a084241ee


x86_64-linux

✅ 1 package built:
  • rot8

@Smona

Smona commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Thanks @kurnevsky! I wasn't aware of the Cargo.lock removal 'til now. Would you be okay waiting a few days on this to give the upstream maintainer some time to respond on the lockfile removal?

@kurnevsky

Copy link
Copy Markdown
Member Author

Sure, but it's been a while already: efernau/rot8#133 (and first it was asked in efernau/rot8@9cd14c9)

@Smona

Smona commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

For sure. I don't have the highest hopes that we'll get a timely response/fix, but I didn't see anyone making actual arguments for the restoration of the lockfile, so I thought I should at least make some. I was also the core contributor for the changes in v1 so I'm hoping that will give my request a little more weight.

If we don't get a response by Friday I say let's go ahead and merge this for now. Nice job on the workaround, the implementation of that LGTM!

@Smona Smona left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, let's go ahead and merge this! i'll put up a PR to remove the lockfile if efernau decides to restore it

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 14, 2026
@Sigmanificient
Sigmanificient added this pull request to the merge queue Aug 15, 2026
Merged via the queue into NixOS:master with commit 9b74e4a Aug 15, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants