Skip to content

Conversation

@wolfgangwalther
Copy link
Contributor

This label is now managed by Nixpkgs CI. Technically it doesn't hurt to manage it via ofborg, too, but ofborg is too quick sometimes. The scheduled labeler in nixpkgs CI works with a bit of delay and thus doesn't temporarily label a PR conflicted while changing base branches and pushing again.

As discussed in NixOS/nixpkgs#422906 (comment).

cc @philiptaron

This label is now managed by Nixpkgs CI.
Copy link

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I'm not familiar with the ofBorg branches: is released the correct target?

@wolfgangwalther
Copy link
Contributor Author

I am not either, but it's the only branch (except two dependabot branches), so.. yes :)

@wolfgangwalther
Copy link
Contributor Author

In 424162 ofborg and nixpkgs-ci are playing ping-pong with the merge conflict label. Clearly, ofborg has other ideas about the merge status than nixpkgs-ci and GitHub.

So we should really disable this.

@dasJ could you please look at this PR or alternatively onboard me in terms of how to merge and deploy stuff as mentioned in #695 (comment)?

@sternenseemann
Copy link
Member

@wolfgangwalther ofborg is right in that case as there is no actual conflict, i.e. git can merge that branch automatically.

@wolfgangwalther
Copy link
Contributor Author

Well, "being right" is not what we want to indicate, though. GitHub's UI doesn't allow merging, because it identifies a merge conflict. The label should reflect that, to be able to easily filter out PRs where you can't hit the button.

Conni2461 added a commit to NixOS/ofborg-infrastructure that referenced this pull request Jul 14, 2025
@Conni2461
Copy link
Member

diff looks good to me, thanks. i cant merge here, i asked dasJ in private if he can merge, but i just deployed that change to production: NixOS/ofborg-infrastructure@1881981

@wolfgangwalther
Copy link
Contributor Author

@Conni2461 is that deployment live already?

In NixOS/nixpkgs#424162, ofborg is still doing something about this label. Did I forget any related code? I don't think so.

@Conni2461
Copy link
Member

you were right i havent deployed the right host the first time i deployed, but i fixed that right after you pinged me last week and i just checked the logs and ofborg didnt add another label for merge conflicts since then. so this is good to go.

thanks again :)

@Conni2461 Conni2461 merged commit 4caed13 into NixOS:released Jul 22, 2025
2 checks passed
@wolfgangwalther wolfgangwalther deleted the fewer-labels branch July 22, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants