Repository navigation
fix(lexical): auto-provision Kiwi model on first Korean use - #36
Merged
Merged
Conversation
Download the official Kiwi v0.23.0 base model into the local cache when MAILCRAWL_KIWI_MODEL is unset, split missing-model vs WASM errors, resolve kiwi-nlp WASM from the package tree when the bin is relocated, and report Korean analyzer readiness from mailcrawl doctor --json (with --fix). Closes #35
# Conflicts: # src/cli/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Summary
MAILCRAWL_KIWI_MODELis unsetkiwi-nlpWASM from the package tree when the CLI is invoked through a relocated bin shimmailcrawl doctor --jsonand provision withmailcrawl doctor --fixVerification
npx tsc -p tsconfig.json --noEmitnpx tsc -p tsconfig.jsonnpx vitest run(23 files, 74 tests)npm run validate:skilltests/issue-35.test.tssearch --mode bm25 --json '결제'withoutMAILCRAWL_KIWI_MODELhits the Korean fixture; Englishrenewalstill hitsdoctor --jsonreportskorean.status=missing-model;doctor --fixdownloadscong.mdland reportsready