LLT-6769: add tp lite stats collection #1648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
stalowyjez
force-pushed
the
LLT-6647-use_libfirewall
branch
2 times, most recently
from
4cec59b to
ba678a2
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
6e24aab to
a6c769b
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
stalowyjez
force-pushed
the
LLT-6647-use_libfirewall
branch
2 times, most recently
from
ba18143 to
43c943a
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
e7d365c to
4627210
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
4627210 to
9a6685a
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
9a6685a to
b006869
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
tomaszklak
reviewed
Jan 23, 2026
| })?; | ||
| { | ||
| let mut old_cb = Box::new(collect_stats_cb); | ||
| let mut cb = self.tp_lite_stats_cb.callback.write(); |
Contributor
There was a problem hiding this comment.
I don't think we need the old value, so a simple assignment should be enough - no need for swap.
Contributor
Author
There was a problem hiding this comment.
I added a comment to explain it, let me know if it clears it up or if you want me to change something
Contributor
There was a problem hiding this comment.
Could we change the order of those two operations to make it simpler, and avoid this temporal coupling? First call libfw_enable_tp_lite_stats_collection and only if it succeeds, do we update the callback field?
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
b006869 to
28fbe4e
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
28fbe4e to
50bf5a2
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
50bf5a2 to
67dce12
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
tomaszklak
reviewed
Jan 28, 2026
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
67dce12 to
e5bb73f
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
tomaszklak
reviewed
Jan 28, 2026
Contributor
|
I can already give +1, regardless of #1648 (comment) |
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
e5bb73f to
eb1cc25
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
mathiaspeters
force-pushed
the
LLT-6769_add_tp_lite_stats_collection
branch
from
eb1cc25 to
bc74e7e
Compare
mathiaspeters
temporarily deployed
to
Internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to add TP-Lite stats collection to libtelio
Solution
The stats collection is implemented in libfirewall so we just need to configure that. Some inbound packets will be rewritten slightly which requires the packet buffer for that to be mutable, which requires changes to neptun. And tests need a newer version of libfirewall which means that libtelio-build needs to be updated as well
☑️ Definition of Done checklist