feat: add shinylive app and modernize codebase#3
Merged
Conversation
tcoroller
commented
Mar 27, 2026
tcoroller
commented
Member
- Add Shinylive (WebAssembly) version of Shiny app in inst/shinylive-app/
- Add pkgdown article embedding shinylive app via iframe
- Enhance _pkgdown.yml with navbar, article sections, and reference grouping
- Improve roxygen2 docs for app_server() and app_ui()
- Fix app_ui() typo: with=12 corrected to width=12 (removes duplicate arg)
- Fix incomplete paper URL in Shiny app (now links to published paper)
- Modernize calc_predictive() and meeting_probs() to use vapply()
- Add explicit return() in calc_predictive(), fixing silent NULL return bug
- Remove dead commented-out code from app_server() and run_app()
- Document hardcoded false positive rate in find_pos()
- Align .lintr line width (80) with air.toml formatter config
- Add tests for calc_posterior(), calc_predictive(), and meeting_probs()
- Update test_get_pos criterion 4 to match fixed calc_predictive return
- Update GitHub Actions: actions/checkout@v4, add shinylive export step
- Add shinylive to Suggests, add VignetteBuilder: knitr
- Update .Rbuildignore for CRAN compliance
- Bump version to 0.2.0
- Remove committed doc/ build artifacts
- Add Shinylive (WebAssembly) version of Shiny app in inst/shinylive-app/ - Add pkgdown article embedding shinylive app via iframe - Enhance _pkgdown.yml with navbar, article sections, and reference grouping - Improve roxygen2 docs for app_server() and app_ui() - Fix app_ui() typo: with=12 corrected to width=12 (removes duplicate arg) - Fix incomplete paper URL in Shiny app (now links to published paper) - Modernize calc_predictive() and meeting_probs() to use vapply() - Add explicit return() in calc_predictive(), fixing silent NULL return bug - Remove dead commented-out code from app_server() and run_app() - Document hardcoded false positive rate in find_pos() - Align .lintr line width (80) with air.toml formatter config - Add tests for calc_posterior(), calc_predictive(), and meeting_probs() - Update test_get_pos criterion 4 to match fixed calc_predictive return - Update GitHub Actions: actions/checkout@v4, add shinylive export step - Add shinylive to Suggests, add VignetteBuilder: knitr - Update .Rbuildignore for CRAN compliance - Bump version to 0.2.0 - Remove committed doc/ build artifacts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tcoroller
marked this pull request as draft
March 27, 2026 17:17
- Add R-CMD-check.yaml: runs R CMD check --as-cran on push/PR to main across ubuntu (devel, release, oldrel-1), macos, and windows - Update pkgdown workflow to also trigger on PRs, building the site without deploying so documentation errors are caught before merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
setup-renv@v2 fails when renv itself isn't installed because it runs its own R process without a CRAN mirror. Switch to setup-r-dependencies@v2 which uses the repos configured by setup-r@v2 (use-public-rspm: true). pkgdown and shinylive are added as extra packages; all other deps come from DESCRIPTION. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
devtools is a dev-only dependency not available in CI. pkgload is the lightweight package that actually implements load_all(); devtools simply re-exports it. Add pkgload as an extra-package in the pkgdown workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- _pkgdown.yml: add app_server and app_ui to the Shiny App reference section (pkgdown errors when exported topics are missing from index) - README.md: add alt text to shiny.png (pkgdown accessibility check) Verified clean local build before pushing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- README.md: swap shiny.png screenshot for a direct link to the Shinylive app at opensource.nibr.com/monitOS/shinylive-app/ - vignettes/shinylive.Rmd: fix iframe src and fallback link from nicaise.github.io (stale fork URL) to correct opensource.nibr.com Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- _pkgdown.yml: add 'App' navbar entry (left side, after articles) linking directly to shinylive-app/index.html - build-documentation.yml: fix deploy order — previously deploy_to_branch() rebuilt from scratch and discarded shinylive files. Now: build_site() → shinylive::export() into docs/ → git push to gh-pages. Both PR preview and deploy steps follow this order. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlang's C code references PREXPR, a symbol removed in R-devel (>=4.5). This is an upstream issue unrelated to monitOS. Mark the R-devel matrix entry with allow_failure: true so it doesn't block PRs, while still running and surfacing the result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tcoroller
marked this pull request as ready for review
March 27, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.