Deck registration Svelte conversion (read-only)#802
Open
rlankin wants to merge 12 commits into
Open
Conversation
- Fixed card type images - Added Edit Deck link - Added basic error handling to loadPrintings() - Cleaned up TODO comments
rlankin
changed the title
plural
requested changes
May 26, 2026
Contributor
There was a problem hiding this comment.
the username for the logged in player is not auto-populated on this view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of the deck registration page. Currently, it is read-only, so no deck selections are saved and any previously selected decks are not yet loaded.
This PR is actually much smaller than it appears, because the tools are on one today:
prettierdecided that a bunch of existing files needed to be touched - I didn't change anything related toTournamentList, for example.RegistrationCardis the general player registration info section on theTournamenttab, so I renamed it to be more specific and usedRegistrationfor the new beta deck registration page.These changes have become cumbersome enough that I'm splitting this conversion up - deck editing will come next, followed by tests.