Reputation Merkle-sum tree with incremental on-chain scoring - #431
Open
cyber-punk112 wants to merge 1 commit into
Open
Reputation Merkle-sum tree with incremental on-chain scoring#431cyber-punk112 wants to merge 1 commit into
cyber-punk112 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the jotelfootball-tech's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Hey @muhammad-codes112. Thanks for this, two things to resolve before merge:
Since this touches escrow contract code, let me know once both are sorted and I'll take a close look at the logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification notes (per repo convention, no CI run in this environment):
cargo check --testspasses cleanly for htlc-core and escrow (workspace members) and for the reputation crate (checked standalone, see below) — only pre-existing deprecation warnings, no errors introduced by this change.cargo testcould not be executed for the reputation crate here: it hits a Windows-GNU linker limit (export ordinal too large) when linking the soroban-sdk dependency graph as a DLL — an environment/toolchain issue unrelated to this change, not something introduced by it.reputationcrate is not listed incontracts/Cargo.toml's workspacemembers(nor excluded), and independently of that,jury_arbitration.rs/jury_tests.rsand theDECAY_TABLEconstant (declared[u32; 366]but with only 365 entries) already fail to compile onmain, unrelated to reputation scoring. None of that was touched here — out of scope per the instructions not to fix a pre-existing broken build/test setup — but it's worth flagging since it means the reputation crate currently isn't exercised by any workspace-widecargo test/CI run.contracts/htlc-core/src/mst.rs's own unit tests,contracts/reputation/src/mst_test.rs,contracts/reputation/src/benchmarks.rs) use plain#[test]functions with a small deterministic PRNG for "randomized" coverage rather than adding a property-testing dependency to the reputation crate (proptest already exists in escrow's dev-dependencies but not reputation's).Closes #387