fix: accept bare hosts and update code generator#130
Merged
tim-thacker-nullify merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: accept bare hosts and update code generator#130tim-thacker-nullify merged 1 commit intomainfrom
tim-thacker-nullify merged 1 commit intomainfrom
Conversation
SanitizeNullifyHost now accepts bare hosts (e.g. acme.nullify.ai) in addition to api-prefixed hosts. The code generator template is updated to include the apiHost prefix logic so regeneration preserves the behavior. User-facing messages updated accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jonathanlam
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SanitizeNullifyHostnow accepts bare hosts (e.g.acme.nullify.ai) by only validating the.nullify.aisuffix, instead of requiring theapi.prefixscripts/generate/main.goto includeapiHostprefix logic, so regeneratingclient.gopreserves the bare-host supportapi.<your-instance>.nullify.aito<your-instance>.nullify.aiTest plan
go build ./...compiles cleanlygo test ./...all tests passSanitizeNullifyHost("acme.nullify.ai")returns"acme.nullify.ai", nilSanitizeNullifyHost("api.acme.nullify.ai")still returns"api.acme.nullify.ai", nilclient.gowith theapiHostlogic🤖 Generated with Claude Code