sedimentation_speed interface + effective sedimentation for total water#458
sedimentation_speed interface + effective sedimentation for total water#458glwagner wants to merge 4 commits into
sedimentation_speed interface + effective sedimentation for total water#458Conversation
Rename the primary microphysics sedimentation interface for clarity: - `fall_speed` → `sedimentation_speed` (per-tracer positive magnitude) - `model.fall_velocities` → `model.bulk_sedimentation_velocities` (precomputed aggregates) - Related helpers renamed consistently throughout Update developer documentation with comprehensive sedimentation speed section covering notation, interface tables, math, and concrete examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ion_velocity Build aggregate (speed_field, humidity_field) pairs generically from sedimentation_speed + prognostic_field_names, filtering to mass tracers (names starting with :ρq). This eliminates a per-scheme interface function that duplicated information already available from sedimentation_speed. Also rename _sedimentation_velocity → get_sedimentation_velocity since the _ prefix is reserved for @kernel functions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Docs build fails: https://github.com/NumericalEarth/Breeze.jl/actions/runs/21804612301/job/62905752336?pr=458#step:7:39 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
looking into it |
|
Still digesting this, but here is a summary of one reason for the instability:
In other words. In order to consistently include this advection term in multiple equations, it has to be computed in exactly the same way. We can't use WENO to compute the moisture density flux and rain flux separately, because the advection fluxes are numerically different. This is serious difficulty in prognosing total water. I'd like to think about it a bit more. cc @kaiyuan-cheng This difficulty also must be addressed if we wanted to include the hydrometeor fluxes in the density equation, or the energy equation (when using static or total energy). |
|
superceded by #614 |
This PR implements a "sedimentation interface" for microphysics schemes to specify the sedimentation speed of hydrometeors. The intent is to produce a system that automatically computes the effective sedimentation speed of aggregate quantities: total liquid fraction$q^l$ , total ice fraction $q^i$ (both diagnostic quantities, possibly not stored), and finally total water fraction $q^t$ (which is required to consistently advect total moisture density as well as density).