Allows construction of AnelasticDynamics and compilation of time_step! with Reactant#463
Allows construction of AnelasticDynamics and compilation of time_step! with Reactant#463dkytezab wants to merge 16 commits into
AnelasticDynamics and compilation of time_step! with Reactant#463Conversation
|
The history looks messed up 🥲 |
| include("Timesteppers.jl") | ||
| using .TimeSteppers | ||
|
|
||
| include("MassConservation.jl") |
There was a problem hiding this comment.
I think this is more correctly call AtmosphereModels (the logic here is that the AtmosphereModels module in the extension will define functions that pertain to src/AtmosphereModels... if that makes sense)
|
Can we remove all the unrelated commits from this PR? I can do the git surgery if you want. |
|
that would be perfect, thank you! |
557670b to
591f037
Compare
|
Surgery done. Now you need to run |
|
Double check I didn't mess up anything 😃 |
|
LGTM, gonna just add my changes following @glwagner's suggestion |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
|
Same mixed topology problem: https://github.com/NumericalEarth/Breeze.jl/actions/runs/21874130501/job/63137883354?pr=463#step:7:586 |
|
See CliMA/Oceananigans.jl#5093. @giordano I wonder if we can create separate environments for tests that use Reactant and those that don't? I think we can solve this problem by bumping up the minimum version to |
|
that 1.10 issue is definitely a bug that should be fixed [and from the looks of would not be limited to 1.10, we just got unlucky with julia dispatch on that version]. mwe would be helpful |
| # support is improved. | ||
| if VERSION >= v"1.12" | ||
| delete!(testsuite, "reactant_compilation") | ||
| delete!(testsuite, "reactant_compilation_compressible") |
There was a problem hiding this comment.
1.12 should be fine [tho @giordano mentioned slow to compile], was there another reason for removing?
There was a problem hiding this comment.
also any mwes for it being slow are also helpful
There was a problem hiding this comment.
Probably just bc of the warning that used to be emitted, right? @dkytezab put 1.12 back!
AnelasticDynamics and compilation of timesteppingAnelasticDynamics and compilation of time_step! with Reactant
See #462.