Add Reactant correctness check for AtmosphereModel.#687
Conversation
There was a problem hiding this comment.
Shouldn't run only on the GPU jobs? Also, it may be easier to move all these tests in a dedicate directory (reactant/?) and then in
Lines 13 to 20 in d978c46
reactant/. Edit: I went on and did that.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ParallelTestRunner fixes the seed anyway.
|
I believe that the errors here https://github.com/NumericalEarth/Breeze.jl/actions/runs/25581771362/job/75102082127?pr=687#step:11:536 are due primarily to EnzymeAD/Reactant.jl#2870. Basically, when we compile with Reactant, we alias the initial state rather than storing it as a copy, causing the RK3 substeps to be incorrect. This enters here Breeze.jl/src/TimeSteppers/ssp_runge_kutta_3.jl Lines 150 to 156 in 10c0d0b My workaround was instead to use a kernel to copy each of the prognostic fields, which I can implement now for the time being if that sounds good There may also be an issue with |
Closes #683. Checking field equality before and after a single timestep.