Cleans implicit imports + Add ExplicitImports quality assurance testsuite#239
Cleans implicit imports + Add ExplicitImports quality assurance testsuite#239navidcy wants to merge 30 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@giordano I tried to follow Oceananigans practices. The tests pass here now. Could you have a look? There is a chance I misunderstood something. I am a bit confused because I was thinking that the end goal would be that there is no |
|
8497c2a tried to have all extension of methods explicit. |
…alEarth.jl into ncc/clean-imports
|
For what is worth, the way I go when I want to implement ExplicitImports is to run using ExplicitImports, MyPackage
print_explicit_imports(MyPackage)or using ExplicitImports, MyPackage
print_explicit_imports(MyPackage.Submodule)if MyPackage is very large, and working on a submodule-basis is more efficient (that's what I've been doing in Oceananigans). This is the recommended approach in the docs and is quite nice because it shows you exactly what's needed to change, and how to change it. Then I use some judgement (for example it always suggests |
|
I've done it... I believe this is ready to merge? |
Closes #229