Skip to content

Soil Heat Diffusion Example (#91)#103

Open
elenamiralles wants to merge 10 commits into
NumericalEarth:mainfrom
elenamiralles:example/soil-heat-diffusion
Open

Soil Heat Diffusion Example (#91)#103
elenamiralles wants to merge 10 commits into
NumericalEarth:mainfrom
elenamiralles:example/soil-heat-diffusion

Conversation

@elenamiralles
Copy link
Copy Markdown

@elenamiralles elenamiralles commented Apr 9, 2026

Add soil heat diffusion example with analytical validation

Closes #91

@bgroenks96 bgroenks96 changed the title Soil Heat Diffusion Example (Addresses #91) Soil Heat Diffusion Example (#91) Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@bgroenks96 bgroenks96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, thanks! I left a few comments below.

I am also interested in hearing your feedback; did you run into any issues? Was anything confusing for you or missing clear documentation?

Comment thread examples/soil_heat_diffusion.jl Outdated
Comment thread examples/soil_heat_diffusion.jl Outdated
Comment thread examples/soil_heat_diffusion.jl Outdated
Comment thread examples/soil_heat_diffusion.jl Outdated
@elenamiralles
Copy link
Copy Markdown
Author

Hi @bgroenks96, thank you for the review. I will update the code asap. With respect to documentation everything was very straightforward! One thing that I think could use some improvement is time to download? Maybe it was just my machine but it took 20 min to import the Terrarium package initially.

@bgroenks96
Copy link
Copy Markdown
Collaborator

One thing that I think could use some improvement is time to download? Maybe it was just my machine but it took 20 min to import the Terrarium package initially.

That's not good! Do you mean the initial installation of the package? That can definitely be slow in Julia due to precompilation time, but 20 minutes seems excessive to me, unless your internet connection was quite slow.

@elenamiralles
Copy link
Copy Markdown
Author

Yes, it was the initial installation! I also was surprised by how long it took. It could have been my internet connection but I've not had that problem with other packages yet.

@elenamiralles elenamiralles marked this pull request as ready for review April 21, 2026 17:35
@bgroenks96 bgroenks96 self-requested a review May 11, 2026 12:02
@bgroenks96 bgroenks96 force-pushed the example/soil-heat-diffusion branch from 2fa63f9 to 65dd159 Compare May 11, 2026 12:21
@bgroenks96
Copy link
Copy Markdown
Collaborator

Hey @elenamiralles, sorry for the long silence. The last few weeks were a bit hectic with a lot of traveling, but I'm back now. I think this looks generally good. I updated the branch with the latest changes from main and merged your example script with the existing soil heat column example in 65dd159. I think this makes sense because they are anyway the same basic model setup.

Is there anything else you'd like to add here? One thing that might be nice is testing against the analytical solution to the Stefan problem, but we don't necessarily have to do that in this PR.

@bgroenks96 bgroenks96 force-pushed the example/soil-heat-diffusion branch from af9a885 to c1d0a77 Compare May 11, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create soil heat example based on analytical test case

2 participants