chore: add when guard to install/setup.yml to handle missing binary_url gracefully

[O1ahmad]

Note

Low Risk
Low risk: adds a simple when condition to skip the download task when binary_url is undefined/empty, reducing failures without changing the download logic itself.

Overview
Prevents tasks/install/setup.yml from attempting to include the binary download tasks unless binary_url is defined and non-empty, allowing installs to proceed gracefully when no binary URL is provided.

^{Written by Cursor Bugbot for commit 53a11db. This will update automatically on new commits. Configure here.}

Summary by CodeRabbit

• Bug Fixes
  • Tool installation now skips download when no URL is configured, preventing unnecessary operations.
  • Installer and cleanup steps now handle missing or empty download URLs safely, avoiding errors and unintended removal attempts when no valid binary name exists.

[coderabbitai]

Warning

Rate limit exceeded

@O1ahmad has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 334fe0e and 8e9e8a6.

📒 Files selected for processing (2)

• handlers/main.yml
• tasks/install/setup.yml

📝 Walkthrough

Walkthrough

Added guards around binary-related tasks and handler paths so download/include and file-removal logic only run when binary_url is defined and yields a non-empty basename; defaults are used to avoid errors when binary_url is undefined.

Changes

Cohort / File(s)	Summary
Install task guard tasks/install/setup.yml	include_tasks now runs only when binary_url is defined and non-empty; download of tool binary is conditional.
Handler path safety handlers/main.yml	Wrapped basename(binary_url) usages with default('', true) and adjusted guards so removal and path derivation skip when binary_url is undefined or yields empty/"." basename.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: add package/install-only setup mode #43: Modifies the same Ansible install flow and handlers to guard binary download/include and basename-based removal logic.

Poem

I nibble lines of YAML bright,
A tiny guard to steer the flight.
Skip the download if no URL's there,
Quiet paws, no needless wear.
Hoppy deploys — handled with care. 🐇🎋

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding a when guard to handle missing binary_url gracefully, which matches the core modification in tasks/install/setup.yml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ahmad/add_binary_download_guard

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[O1ahmad]

@cursor review this PR

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

[cursor]

Length filter on null binary_url causes runtime error

High Severity

The when guard will error instead of gracefully skipping. In defaults/main.yml, binary_url is declared with no value (binary_url:), making it null/None. The binary_url is defined check passes because the variable exists in the namespace, and then binary_url | length raises a TypeError since Jinja2's length filter cannot operate on None. Using binary_url | default('', true) | length > 0 or adding a binary_url is not none check would avoid this.

 

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@handlers/main.yml`:
- Around line 65-74: Extract the repeated complex expression
"(binary_file_name_override | default((binary_url | default('', true)) |
basename))" into a task-level variable (e.g., binary_name) in the "Remove
extracted files or moved binary" task, then reference binary_name in the
ansible.builtin.file path and in the when conditions (replace the three
occurrences with binary_name, keep the checks binary_name | length > 0 and
binary_name != "."); this shortens the long line to under 120 chars and removes
duplication while preserving behavior.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53a11db and 334fe0e.

📒 Files selected for processing (2)

• handlers/main.yml
• tasks/install/setup.yml

🚧 Files skipped from review as they are similar to previous changes (1)

• tasks/install/setup.yml